fix(rpc): support eth_simulateV1 with flashblocks#880
Open
realmehmetali wants to merge 1 commit into
Open
Conversation
realmehmetali
force-pushed
the
codex/fix-flashblocks-eth-simulate
branch
from
July 18, 2026 21:28
9671612 to
d19e561
Compare
realmehmetali
force-pushed
the
codex/fix-flashblocks-eth-simulate
branch
from
July 18, 2026 21:31
d19e561 to
c998602
Compare
Delegate state-root configuration to the wrapped OP-Reth API so simulation requests no longer hit a panic path.
realmehmetali
marked this pull request as ready for review
July 18, 2026 21:33
realmehmetali
requested review from
0xForerunner,
0xOsiris,
Dzejkop,
Kemperino,
alessandromazza98,
cichaczem,
karankurbur,
kilianglas,
murph and
piohei
as code owners
July 18, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_simulateV1OpEthApiWhy
eth_simulateV1consultscompute_state_root_for_eth_simulatewhile serving simulations. The Flashblocks wrapper currently implements that method withunimplemented!(), so a standards-based simulation request can panic its RPC task.Reliable simulation is especially important for automated wallets and AI agents that preflight multi-step state transitions before submitting transactions. This keeps World Chain's Flashblocks API aligned with the upstream OP-Reth implementation.
Validation
cargo fmt --all -- --checkcargo check -p world-chain-rpc --all-targetscargo test -p world-chain-rpc --lib(11 passed)Note
Low Risk
Single-method delegation with no new Flashblocks-specific logic; aligns behavior with the wrapped OP-Reth API.
Overview
Fixes
eth_simulateV1on the Flashblocks RPC wrapper by implementingcompute_state_root_for_eth_simulateas a forward to the wrappedOpEthApiinstead ofunimplemented!(), which could panic the RPC task when simulations read that setting.Behavior now matches the inner node’s RPC configuration (same pattern as
max_simulate_blocksandcall_gas_limit), with an#[inline]delegate added for consistency.Reviewed by Cursor Bugbot for commit 8f9d954. Bugbot is set up for automated code reviews on this repo. Configure here.