[Rogue] T13/Phase 4 additions, APL tuning, Combat reforging defaults #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337LutZ
reviewed
Nov 12, 2024
1337LutZ
reviewed
Nov 13, 2024
1337LutZ
reviewed
Nov 13, 2024
Contributor
Author
|
Still working on this. Caught something last week so I've been in and out of sleep and haven't been able to focus on this |
Contributor
Author
|
Alright pretty sure I've figured out everything I need to for Combat, everything should be good to go here. |
1337LutZ
approved these changes
Nov 19, 2024
hillerstorm
pushed a commit
to hillerstorm/mop
that referenced
this pull request
Dec 6, 2025
Update Haste softcap & APL variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dagger implementation mirrors that of SimC/Shadowcraft. Likely more APL adjustments that can be made, but ATM I'm being very conservative about additions that could impact T12 sims.
Default gearset selections remain on P3, plan to remain that way until P4 is imminent.