Skip to content

Fix incorrect proc data for Heartsong and Gnomish X-Ray enchants #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NerdEgghead merged 1 commit into from
May 20, 2025
Merged

Fix incorrect proc data for Heartsong and Gnomish X-Ray enchants #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions sim/common/cata/enchant_effects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func init() {
ProcMask: core.ProcMaskSpellDamage | core.ProcMaskSpellHealing,
Outcome: core.OutcomeLanded,
ICD: time.Second * 20,
ProcChance: 0.25,
ProcChance: 0.15,
Bonus: stats.Stats{stats.Spirit: 200},
Duration: time.Second * 15,
})
Expand Down Expand Up @@ -370,17 +370,17 @@ func init() {

// Enchant: 4175, Spell: 81932, Item: 59594 - Gnomish X-Ray Scope
shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
Name: "Gnomish X-Ray Scope",
EnchantID: 4175,
ItemID: 59594,
AuraID: 95712,
Callback: core.CallbackOnSpellHitDealt,
ProcMask: core.ProcMaskRanged,
Outcome: core.OutcomeLanded,
ICD: time.Second * 40,
ProcChance: 0.1,
Bonus: stats.Stats{stats.RangedAttackPower: 800},
Duration: time.Second * 10,
Name: "Gnomish X-Ray Scope",
EnchantID: 4175,
ItemID: 59594,
AuraID: 95712,
Callback: core.CallbackOnSpellHitDealt,
ProcMask: core.ProcMaskRanged,
Outcome: core.OutcomeLanded,
ICD: time.Second * 40,
PPM: 1,
Bonus: stats.Stats{stats.RangedAttackPower: 800},
Duration: time.Second * 10,
})

// Enchant: 4176, Item: 59595 - R19 Threatfinder
Expand Down
4 changes: 2 additions & 2 deletions sim/death_knight/unholy/TestUnholy.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,8 @@ dps_results: {
dps_results: {
key: "TestUnholy-AllItems-EnchantWeapon-Heartsong-4084"
value: {
dps: 49810.29353
tps: 34909.33888
dps: 49810.08893
tps: 34908.95013
}
}
dps_results: {
Expand Down
2 changes: 1 addition & 1 deletion sim/druid/balance/TestBalance.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ dps_results: {
dps_results: {
key: "TestBalance-AllItems-EnchantWeapon-Heartsong-4084"
value: {
dps: 48377.28418
dps: 48376.90074
tps: 45076.6736
}
}
Expand Down
Loading
Loading