Dynamic Encounter Targets #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
active targets separately, with more descriptive names for each, and migrated all spec spell code to use dynamic references to the currently active target count. On branch feature/dynamic-encounter-targets Changes to be committed: modified: sim/common/cata/other_effects.go modified: sim/common/wotlk/shadowmourne.go modified: sim/core/apl_actions_casting.go modified: sim/core/apl_values_encounter.go modified: sim/core/buffs.go modified: sim/core/cast.go modified: sim/core/consumes.go modified: sim/core/environment.go modified: sim/core/health.go modified: sim/core/sim.go modified: sim/core/spell.go modified: sim/core/spell_queueing.go modified: sim/core/target.go modified: sim/core/unit.go modified: sim/death_knight/blood/heart_strike.go modified: sim/death_knight/blood_boil.go modified: sim/death_knight/death_and_decay.go modified: sim/death_knight/ghoul_pet.go modified: sim/death_knight/howling_blast.go modified: sim/death_knight/pestilence.go modified: sim/death_knight/talents_frost.go modified: sim/druid/demoralizing_roar.go modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/apl_values.go modified: sim/druid/feral/rotation_aoe.go modified: sim/druid/hurricane.go modified: sim/druid/items.go modified: sim/druid/mangle.go modified: sim/druid/maul.go modified: sim/druid/starfall.go modified: sim/druid/swipe.go modified: sim/druid/thrash.go modified: sim/druid/typhoon.go modified: sim/druid/wild_mushrooms.go modified: sim/encounters/bwd/magmaw_ai.go modified: sim/encounters/bwd/nefarian_ai.go modified: sim/encounters/dragonsoul/blackhorn_ai.go modified: sim/hunter/explosive_trap.go modified: sim/hunter/multi_shot.go modified: sim/hunter/pet.go modified: sim/hunter/pet_abilities.go modified: sim/mage/arcane_explosion.go modified: sim/mage/blast_wave.go modified: sim/mage/blizzard.go modified: sim/mage/dragons_breath.go modified: sim/mage/flame_orb.go modified: sim/mage/flamestrike.go modified: sim/mage/freeze.go modified: sim/mage/frostfire_orb.go modified: sim/mage/living_bomb.go modified: sim/mage/talents_fire.go modified: sim/paladin/consecration.go modified: sim/paladin/guardian_of_ancient_kings.go modified: sim/paladin/holy_wrath.go modified: sim/paladin/protection/avengers_shield.go modified: sim/paladin/seal_of_righteousness.go modified: sim/paladin/talents_protection.go modified: sim/paladin/talents_retribution.go modified: sim/priest/mind_sear.go modified: sim/rogue/combat/blade_flurry.go modified: sim/rogue/combat/killing_spree.go modified: sim/rogue/fan_of_knives.go modified: sim/rogue/subtlety/sanguinary_vein.go modified: sim/shaman/chain_lightning.go modified: sim/shaman/earthquake.go modified: sim/shaman/elemental/thunderstorm.go modified: sim/shaman/enhancement/lavalash.go modified: sim/shaman/fire_elemental_spells.go modified: sim/shaman/fire_totems.go modified: sim/shaman/firenova.go modified: sim/warlock/demonology/hand_of_guldan.go modified: sim/warlock/demonology/metamorphosis.go modified: sim/warlock/infernal.go modified: sim/warlock/pets.go modified: sim/warlock/seed.go modified: sim/warrior/arms/bladestorm.go modified: sim/warrior/arms/sweeping_strikes.go modified: sim/warrior/demoralizing_shout.go modified: sim/warrior/fury/TestFury.results modified: sim/warrior/heroic_leap.go modified: sim/warrior/heroic_strike_cleave.go modified: sim/warrior/protection/shockwave.go modified: sim/warrior/revenge.go modified: sim/warrior/sunder_armor.go modified: sim/warrior/talents.go modified: sim/warrior/thunder_clap.go modified: sim/warrior/whirlwind.go
permanently disabled in order to test the spell code migrations. On branch feature/dynamic-encounter-targets Changes to be committed: modified: proto/common.proto modified: sim/core/target.go modified: sim/core/test_utils.go modified: sim/warrior/arms/TestArms.results
dodoels
reviewed
Jun 27, 2025
Blackhorn encounter AI accordingly. On branch feature/dynamic-encounter-targets Changes to be committed: modified: proto/common.proto modified: sim/core/target.go modified: sim/core/target_ai.go modified: sim/core/unit.go modified: sim/encounters/dragonsoul/blackhorn_ai.go modified: sim/warrior/arms/TestArms.results
NerdEgghead
changed the title
| if nextTarget.IsEnabled() { | ||
| return nextTarget | ||
| } else { | ||
| return nextTarget.NextActiveTarget() |
Contributor
There was a problem hiding this comment.
Won't this cause problems if every target is disabled for some reason? Shouldn't happen of course but never know.
Contributor
Author
There was a problem hiding this comment.
This situation shouldn't be possible because of the panic I put in removeInactiveTarget().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.