Port stats panel overhaul #1522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ste inheritance and added skull banner and stormlash to default raid buffs (following the same practise from other specs)
Feature/fix neteyes june
- Clear stale DoT state from debuffState map if DoT is not active on primary target - Remove redundant igniteRef == nil check in spreading loop - Refactor Ignite spreading logic for secondary targets - Update test results
Feature/warrior
On branch feature/dynamic-targets-port Changes to be committed: modified: proto/common.proto modified: sim/core/apl_actions_casting.go modified: sim/core/apl_values_encounter.go modified: sim/core/buffs.go modified: sim/core/cast.go modified: sim/core/environment.go modified: sim/core/health.go modified: sim/core/sim.go modified: sim/core/spell.go modified: sim/core/spell_queueing.go modified: sim/core/target.go modified: sim/core/target_ai.go modified: sim/core/test_utils.go modified: sim/core/unit.go modified: sim/encounters/dragonsoul/blackhorn_ai.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/consumes.go modified: sim/core/spell_result.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/monk/spinning_crane_kick.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/aura.go modified: sim/warrior/banners.go
added helpers for pre-calculating AoE damage results and dealing the damage in one batch. On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell.go modified: sim/core/spell_result.go modified: sim/warrior/heroic_leap.go modified: sim/warrior/warrior.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell.go modified: sim/core/spell_result.go modified: sim/warrior/heroic_strike_cleave.go modified: sim/warrior/warrior.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell.go modified: sim/warrior/passives.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/warrior/talents.go
CalcAndDealCleaveDamageWithVariance() helpers On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/warrior/protection/revenge.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/aura.go modified: sim/core/spell_result.go modified: sim/warlock/affliction/affliction.go modified: sim/warlock/affliction/seed_of_corruption.go modified: sim/warlock/corruption.go modified: sim/warlock/demonology/carrion_swarm.go modified: sim/warlock/demonology/chaos_wave.go modified: sim/warlock/demonology/corruption.go modified: sim/warlock/demonology/drain_life.go modified: sim/warlock/demonology/fel_guard.go modified: sim/warlock/demonology/felflame.go modified: sim/warlock/demonology/hand_of_guldan.go modified: sim/warlock/demonology/hellfire.go modified: sim/warlock/demonology/immolation_aura.go modified: sim/warlock/demonology/talents.go modified: sim/warlock/demonology/void_ray.go modified: sim/warlock/destruction/felflame.go modified: sim/warlock/destruction/fire_and_brimstone_conflagrate.go modified: sim/warlock/destruction/fire_and_brimstone_immolate.go modified: sim/warlock/destruction/fire_and_brimstone_incinerate.go modified: sim/warlock/destruction/rain_of_fire.go modified: sim/warlock/drain_life.go modified: sim/warlock/felflame.go modified: sim/warlock/hellfire.go modified: sim/warlock/infernal.go modified: sim/warlock/items.go modified: sim/warlock/warlock.go
reduce copy-pasted code. On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/shaman/fire_totems.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell.go modified: sim/shaman/enhancement/firenova.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/mage/blizzard.go
On branch feature/dynamic-targets-port Changes to be committed: modified: sim/core/spell_result.go modified: sim/monk/xuen_pet.go
[Prot] Update prot P1 preset
Move Raid CDs to separate sections
Update charge and Shattering Throw
Change shattering throw ID in UI
Fix Charge SpellID
Fix default raid buff for some specs
Remove tristate from tricks
Fix Demo Banner actionID
On branch guardian Changes to be committed: modified: sim/druid/druid.go modified: sim/druid/guardian/TestGuardian.results modified: sim/druid/guardian/talents.go modified: sim/druid/guardian/tank.go modified: sim/druid/guardian/tank_test.go new file: sim/druid/rejuvenation.go modified: sim/druid/talents.go modified: sim/druid/tranquility.go modified: ui/druid/guardian/apls/default.apl.json
On branch guardian Changes to be committed: modified: sim/druid/guardian/TestGuardian.results modified: sim/druid/guardian/talents.go modified: sim/druid/guardian/tank.go modified: sim/druid/guardian/tank_test.go modified: ui/druid/guardian/apls/default.apl.json
On branch guardian Changes to be committed: modified: sim/druid/guardian/TestGuardian.results modified: sim/druid/guardian/tank_test.go modified: sim/druid/talents.go
Guardian Level 90 Talents
github-actions
bot
added
Hunter
Mage
Paladin
Priest
Death Knight
Druid
Rogue
Shaman
Warlock
Warrior
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elemental Shaman
Enhancement Shaman
Blood DK