Skip to content

hunter doesn't get extra rAP from TSA #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 1 commit into from
May 4, 2025
Merged

hunter doesn't get extra rAP from TSA #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions sim/hunter/TestP1Hunter.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ character_stats_results: {
final_stats: 0
final_stats: 0
final_stats: 2594.2
final_stats: 1834.2
final_stats: 1734.2
final_stats: 0
final_stats: 5
final_stats: 0
Expand Down Expand Up @@ -253,22 +253,22 @@ dps_results: {
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Dwarf-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-LongMultiTarget"
value: {
dps: 873.23606
tps: 934.19433
dps: 850.23872
tps: 911.197
}
}
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Dwarf-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-LongSingleTarget"
value: {
dps: 670.29264
tps: 539.8006
dps: 653.79376
tps: 523.30172
}
}
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Dwarf-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-ShortSingleTarget"
value: {
dps: 726.84287
tps: 594.74859
dps: 709.04723
tps: 576.95294
}
}
dps_results: {
Expand All @@ -295,22 +295,22 @@ dps_results: {
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Orc-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-LongMultiTarget"
value: {
dps: 883.44926
tps: 933.63816
dps: 860.88051
tps: 911.06941
}
}
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Orc-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-LongSingleTarget"
value: {
dps: 686.45831
tps: 550.85926
dps: 670.01165
tps: 534.41259
}
}
dps_results: {
key: "TestP1Hunter-Phase1-Settings-Orc-p0.bis-Hunter-p1-FullBuffs-P1-Consumes-ShortSingleTarget"
value: {
dps: 754.09164
tps: 614.32827
dps: 736.24236
tps: 596.479
}
}
dps_results: {
Expand Down
14 changes: 3 additions & 11 deletions sim/hunter/hunter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ type Hunter struct {
// The aura that allows you to cast Mongoose Bite
DefensiveState *core.Aura

RapidFireAura *core.Aura
BestialWrathPetAura *core.Aura
RapidFireAura *core.Aura
BestialWrathPetAura *core.Aura
}

func (hunter *Hunter) GetCharacter() *core.Character {
Expand All @@ -124,16 +124,8 @@ func (hunter *Hunter) GetHunter() *Hunter {
}

func (hunter *Hunter) AddRaidBuffs(raidBuffs *proto.RaidBuffs) {
if raidBuffs.TrueshotAura && hunter.Talents.TrueshotAura {
hunter.AddStat(stats.RangedAttackPower, map[int32]float64{
25: 0,
40: 50,
50: 75,
60: 100,
}[hunter.Level])
}

}

func (hunter *Hunter) AddPartyBuffs(_ *proto.PartyBuffs) {
}

Expand Down
Loading