Skip to content

make badge of the swarmguard show its trinket aura properly #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 1 commit into from
Oct 6, 2025
Merged

make badge of the swarmguard show its trinket aura properly #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sim/common/item_effects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3584,7 +3584,7 @@ func init() {
})

auraLabel := "Badge of the Swarmguard"
actionID := core.ActionID{SpellID: 26480}
actionID := core.ActionID{ItemID: BadgeOfTheSwarmguard}
trinketAura := core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
Name: auraLabel,
ActionID: actionID,
Expand Down
4 changes: 3 additions & 1 deletion sim/core/aura_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type ProcHandler func(sim *Simulation, spell *Spell, result *SpellResult)
type ProcTrigger struct {
Name string
ActionID ActionID
ActionIDForProc ActionID
Duration time.Duration
Callback AuraCallback
ProcMask ProcMask
Expand Down Expand Up @@ -138,7 +139,8 @@ func ApplyProcTriggerCallback(unit *Unit, aura *Aura, config ProcTrigger) {
func MakeProcTriggerAura(unit *Unit, config ProcTrigger) *Aura {
aura := Aura{
Label: config.Name,
ActionIDForProc: config.ActionID,
ActionID: config.ActionID,
ActionIDForProc: config.ActionIDForProc,
Duration: config.Duration,
}
if config.Duration == 0 {
Expand Down
Loading