Skip to content

update naxx sets to use proper mob type damage calculations #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 1 commit into from
Oct 6, 2025
Merged

update naxx sets to use proper mob type damage calculations #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 53 additions & 18 deletions sim/common/item_sets/item_sets_pve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,20 @@ var ItemSetRegaliaOfUndeadCleansing = core.NewItemSet(core.ItemSet{
// Increases your damage against undead by 2%.
3: func(agent core.Agent) {
character := agent.GetCharacter()
if character.CurrentTarget.MobType == proto.MobType_MobTypeUndead {
character.PseudoStats.DamageDealtMultiplier *= 1.02
}
delta := 1.02

character.Env.RegisterPostFinalizeEffect(func() {
for _, target := range character.Env.Encounter.TargetUnits {
if target.MobType != proto.MobType_MobTypeUndead {
continue
}

for _, at := range character.AttackTables[target.UnitIndex] {
at.DamageDealtMultiplier *= delta
at.CritMultiplier *= delta
}
}
})
},
},
})
Expand All @@ -374,18 +385,20 @@ var ItemSetUndeadSlayersArmor = core.NewItemSet(core.ItemSet{
// Increases your damage against undead by 2%.
3: func(agent core.Agent) {
character := agent.GetCharacter()

delta := 1.02
for _, target := range character.Env.Encounter.TargetUnits {
if target.MobType != proto.MobType_MobTypeUndead {
continue
}

for _, at := range character.AttackTables[target.UnitIndex] {
at.DamageDealtMultiplier *= delta
at.CritMultiplier *= delta
character.Env.RegisterPostFinalizeEffect(func() {
for _, target := range character.Env.Encounter.TargetUnits {
if target.MobType != proto.MobType_MobTypeUndead {
continue
}

for _, at := range character.AttackTables[target.UnitIndex] {
at.DamageDealtMultiplier *= delta
at.CritMultiplier *= delta
}
}
}
})
},
},
})
Expand All @@ -396,9 +409,20 @@ var ItemSetGarbOfTheUndeadSlayer = core.NewItemSet(core.ItemSet{
// Increases your damage against undead by 2%.
3: func(agent core.Agent) {
character := agent.GetCharacter()
if character.CurrentTarget.MobType == proto.MobType_MobTypeUndead {
character.PseudoStats.DamageDealtMultiplier *= 1.02
}
delta := 1.02

character.Env.RegisterPostFinalizeEffect(func() {
for _, target := range character.Env.Encounter.TargetUnits {
if target.MobType != proto.MobType_MobTypeUndead {
continue
}

for _, at := range character.AttackTables[target.UnitIndex] {
at.DamageDealtMultiplier *= delta
at.CritMultiplier *= delta
}
}
})
},
},
})
Expand All @@ -409,9 +433,20 @@ var ItemSetBattlegearOfUndeadSlaying = core.NewItemSet(core.ItemSet{
// Increases your damage against undead by 2%.
3: func(agent core.Agent) {
character := agent.GetCharacter()
if character.CurrentTarget.MobType == proto.MobType_MobTypeUndead {
character.PseudoStats.DamageDealtMultiplier *= 1.02
}
delta := 1.02

character.Env.RegisterPostFinalizeEffect(func() {
for _, target := range character.Env.Encounter.TargetUnits {
if target.MobType != proto.MobType_MobTypeUndead {
continue
}

for _, at := range character.AttackTables[target.UnitIndex] {
at.DamageDealtMultiplier *= delta
at.CritMultiplier *= delta
}
}
})
},
},
})
Loading