Skip to content

[Rogue] Combat EP Updates #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBackstabi merged 1 commit into from
Dec 28, 2025
Merged

[Rogue] Combat EP Updates #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/rogue/assassination/sim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecAssassinationRogue, {

defaults: {
// Default equipped gear.
gear: Presets.P2_GEARSET.gear,
gear: Presets.P3_GEARSET.gear,
// Default EP weights for sorting gear in the gear picker.
epWeights: Presets.ASN_EP_PRESET.epWeights,
// Stat caps for reforge optimizer
Expand Down
14 changes: 7 additions & 7 deletions ui/rogue/combat/presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ export const CBAT_STANDARD_EP_PRESET = PresetUtils.makePresetEpWeights(
Stats.fromMap(
{
[Stat.StatAgility]: 1.0,
[Stat.StatCritRating]: 0.29,
[Stat.StatHitRating]: 0.7,
[Stat.StatHasteRating]: 0.39,
[Stat.StatMasteryRating]: 0.32,
[Stat.StatExpertiseRating]: 0.56,
[Stat.StatCritRating]: 0.42,
[Stat.StatHitRating]: 1.26,
[Stat.StatHasteRating]: 0.52,
[Stat.StatMasteryRating]: 0.46,
[Stat.StatExpertiseRating]: 1.07,
},
{
[PseudoStat.PseudoStatMainHandDps]: 1.63,
[PseudoStat.PseudoStatOffHandDps]: 0.45,
[PseudoStat.PseudoStatMainHandDps]: 1.43,
[PseudoStat.PseudoStatOffHandDps]: 0.39,
},
),
);
Expand Down
5 changes: 2 additions & 3 deletions ui/rogue/combat/sim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecCombatRogue, {

defaults: {
// Default equipped gear.
gear: Presets.P2_GEARSET.gear,
gear: Presets.P3_GEARSET.gear,
// Default EP weights for sorting gear in the gear picker.
epWeights: Presets.CBAT_STANDARD_EP_PRESET.epWeights,
// Stat caps for reforge optimizer
Expand All @@ -45,8 +45,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecCombatRogue, {
const meleeHitSoftCapConfig = StatCap.fromPseudoStat(PseudoStat.PseudoStatPhysicalHitPercent, {
breakpoints: [7.5, 26.5],
capType: StatCapType.TypeSoftCap,
// These are set by the active EP weight in the updateSoftCaps callback
postCapEPs: [0.3 * Mechanics.PHYSICAL_HIT_RATING_PER_HIT_PERCENT, 0],
postCapEPs: [0.26 * Mechanics.PHYSICAL_HIT_RATING_PER_HIT_PERCENT, 0],
});

return [meleeHitSoftCapConfig];
Expand Down
4 changes: 2 additions & 2 deletions ui/rogue/subtlety/presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import P3Gear from './gear_sets/p3_subtlety.gear.json';
// keep them in a separate file.

export const PRERAID_GEARSET = PresetUtils.makePresetGear('P1 Preraid', PreraidGear);
export const P2_T14_GEARSET = PresetUtils.makePresetGear('P2', P2Gear);
export const P3_T15_GEARSET = PresetUtils.makePresetGear('P3', P3Gear);
export const P2_GEARSET = PresetUtils.makePresetGear('P2', P2Gear);
export const P3_GEARSET = PresetUtils.makePresetGear('P3', P3Gear);

export const ROTATION_PRESET_SUBTLETY = PresetUtils.makePresetAPLRotation('Subtlety', SubtletyApl);

Expand Down
8 changes: 4 additions & 4 deletions ui/rogue/subtlety/sim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecSubtletyRogue, {

defaults: {
// Default equipped gear.
gear: Presets.P2_T14_GEARSET.gear,
gear: Presets.P3_GEARSET.gear,
// Default EP weights for sorting gear in the gear picker.
epWeights: Presets.P1_EP_PRESET.epWeights,
// Stat caps for reforge optimizer
Expand Down Expand Up @@ -119,7 +119,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecSubtletyRogue, {
// Preset rotations that the user can quickly select.
rotations: [Presets.ROTATION_PRESET_SUBTLETY],
// Preset gear configurations that the user can quickly select.
gear: [Presets.PRERAID_GEARSET, Presets.P2_T14_GEARSET, Presets.P3_T15_GEARSET],
gear: [Presets.PRERAID_GEARSET, Presets.P2_GEARSET, Presets.P3_GEARSET],
},

autoRotation: (player: Player<Spec.SpecSubtletyRogue>): APLRotation => {
Expand All @@ -146,10 +146,10 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecSubtletyRogue, {
defaultGear: {
[Faction.Unknown]: {},
[Faction.Alliance]: {
1: Presets.P3_T15_GEARSET.gear,
1: Presets.P3_GEARSET.gear,
},
[Faction.Horde]: {
1: Presets.P3_T15_GEARSET.gear,
1: Presets.P3_GEARSET.gear,
},
},
otherDefaults: Presets.OtherDefaults,
Expand Down