forked from wowsims/cata
-
Notifications
You must be signed in to change notification settings - Fork 38
[i18n] Full i18n Support #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8dbc3cb
add centralized i18n support, localize home page with french and english
dodoels e3b923c
improve localization service and add locale text
dodoels 9d1ef5b
ignore vscode folder
dodoels c6ecd9e
update gitignore
dodoels 36f7dfe
revert changes
dodoels 0b7e088
finalize locale setting
dodoels f983d40
fix locale inconsistency
dodoels f15e6ab
fix lang state issue
dodoels 46a64f1
clean up dev code
dodoels 6a915ff
update documentation
dodoels 35ca533
Merge remote-tracking branch 'upstream/master'
dodoels b8ccaf0
resolve conflict
dodoels dea4871
Merge remote-tracking branch 'upstream/master'
dodoels 49d46a2
fix readme redirect link
dodoels e0584fd
fix conflict
dodoels 82e4977
resolve conflict
dodoels 1285b8c
Merge branch 'wowsims:master' into master
dodoels 4211492
Merge branch 'wowsims:master' into master
dodoels 1ffd29a
restructure locale
dodoels c299501
make i18n sychronized, change keys
dodoels fa1edb7
localized all tab titles
dodoels 696ab38
update docs
dodoels c57dc5e
assets/
dodoels 8eca5ae
fix result tab
dodoels 699f8e7
add fr config
dodoels 43c0286
localize template index file
dodoels 90ec553
refactor localization ts
dodoels 1b17f24
clean up localization.ts and fix underscore bug
dodoels fdedfe0
clean up comments
dodoels 96e9714
refactor init function
dodoels f868170
convert all functions to arrow functions
dodoels df16a72
add comments for adding new locales
dodoels 95aac79
localize side bar
dodoels 301e5a8
Merge branch 'wowsims:master' into master
dodoels df37008
Merge branch 'master' into locale-phase-2
dodoels 3310caa
add enum key standardization, class and spec translation by player
dodoels ed8d92f
update class and spec name in sidebar
dodoels 733cff8
resolve conflict
dodoels 88d568a
resolve conflict
dodoels be03d8c
resolve conflict
dodoels b28917d
clean up
dodoels 8d24d39
resolve conflict
dodoels 2787d20
fix translation keys
dodoels 7961435
add stats mapping
dodoels 3ccdea5
Merge pull request #1 from dodoels/locale-phase-2
dodoels 8be676a
update entity mapping, translation, and resolve comments
dodoels d8255ba
move wowhead prefix function
dodoels e7f267c
move stat translation function
dodoels 9f2aab8
convert localization to jsx format
dodoels a296430
Merge remote-tracking branch 'upstream/master'
dodoels 10a125b
Merge branch 'master' of https://github.com/wowsims/mop into HEAD
kayla-glick 6827a9a
Merge pull request #2 from wowsims/kg/resolve-i18n-conflicts
dodoels d3ff0b5
fix unsupported key
brucecaiad 1ceb02d
fix windows query import
dodoels 068d060
Merge pull request #3 from dodoels/lucy-windows
dodoels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,5 +101,6 @@ | |
| ], | ||
| "[go]": { | ||
| "editor.defaultFormatter": "golang.go" | ||
| } | ||
| }, | ||
| "makefile.configureOnOpen": false | ||
| } | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| { | ||
| "landing": { | ||
| "navigation": { | ||
| "home": "Home", | ||
| "simulations": "Simulations", | ||
| "about": "About", | ||
| "toggle": "Toggle navigation" | ||
| }, | ||
| "simulations": { | ||
| "full_raid": "Full Raid Sim" | ||
| }, | ||
| "home": { | ||
| "title": "WoWSims - Mists of Pandaria", | ||
| "description": "A powerful simulation tool for World of Warcraft: Mists of Pandaria", | ||
| "welcomeDescription": "Welcome to WoWSims - Mists of Pandaria! This is a community-driven project to provide class and raid simulations for World of Warcraft® Mists of Pandaria Classic together with the leading theorycrafters and class representatives." | ||
| }, | ||
| "header": { | ||
| "wowsims": "WoWSims", | ||
| "expansion": "Mists of Pandaria", | ||
| "supportDevs": "Support our devs" | ||
| } | ||
| }, | ||
| "common": { | ||
| "phases": { | ||
| "1": "Phase 1 (T14)", | ||
| "2": "Phase 2 (T15)", | ||
| "3": "Phase 3 (T16)" | ||
| }, | ||
| "status": { | ||
| "unlaunched": "Not Yet Supported", | ||
| "alpha": "Alpha", | ||
| "beta": "Beta", | ||
| "launched": "Launched" | ||
| }, | ||
| "classes": { | ||
| "death_knight": "Death Knight", | ||
| "druid": "Druid", | ||
| "hunter": "Hunter", | ||
| "mage": "Mage", | ||
| "monk": "Monk", | ||
| "paladin": "Paladin", | ||
| "priest": "Priest", | ||
| "rogue": "Rogue", | ||
| "shaman": "Shaman", | ||
| "warlock": "Warlock", | ||
| "warrior": "Warrior" | ||
| }, | ||
| "specs": { | ||
| "death_knight": { | ||
| "blood": "Blood", | ||
| "frost": "Frost", | ||
| "unholy": "Unholy" | ||
| }, | ||
| "druid": { | ||
| "balance": "Balance", | ||
| "feral": "Feral", | ||
| "guardian": "Guardian", | ||
| "restoration": "Restoration" | ||
| }, | ||
| "hunter": { | ||
| "beast_mastery": "Beast Mastery", | ||
| "marksmanship": "Marksmanship", | ||
| "survival": "Survival" | ||
| }, | ||
| "mage": { | ||
| "arcane": "Arcane", | ||
| "fire": "Fire", | ||
| "frost": "Frost" | ||
| }, | ||
| "monk": { | ||
| "brewmaster": "Brewmaster", | ||
| "mistweaver": "Mistweaver", | ||
| "windwalker": "Windwalker" | ||
| }, | ||
| "paladin": { | ||
| "holy": "Holy", | ||
| "protection": "Protection", | ||
| "retribution": "Retribution" | ||
| }, | ||
| "priest": { | ||
| "discipline": "Discipline", | ||
| "holy": "Holy", | ||
| "shadow": "Shadow" | ||
| }, | ||
| "rogue": { | ||
| "assassination": "Assassination", | ||
| "combat": "Combat", | ||
| "subtlety": "Subtlety" | ||
| }, | ||
| "shaman": { | ||
| "elemental": "Elemental", | ||
| "enhancement": "Enhancement", | ||
| "restoration": "Restoration" | ||
| }, | ||
| "warlock": { | ||
| "affliction": "Affliction", | ||
| "demonology": "Demonology", | ||
| "destruction": "Destruction" | ||
| }, | ||
| "warrior": { | ||
| "arms": "Arms", | ||
| "fury": "Fury", | ||
| "protection": "Protection" | ||
| } | ||
| }, | ||
| "stats": { | ||
| "strength": "Strength", | ||
| "agility": "Agility", | ||
| "stamina": "Stamina", | ||
| "intellect": "Intellect", | ||
| "spirit": "Spirit", | ||
| "spell_hit": "Spell Hit", | ||
| "spell_crit": "Spell Crit", | ||
| "spell_haste": "Spell Haste", | ||
| "expertise": "Expertise", | ||
| "dodge": "Dodge", | ||
| "parry": "Parry", | ||
| "mastery": "Mastery", | ||
| "attack_power": "Attack Power", | ||
| "ranged_attack_power": "Ranged Attack Power", | ||
| "spell_power": "Spell Power", | ||
| "pvp_resilience": "PvP Resilience", | ||
| "pvp_power": "PvP Power", | ||
| "armor": "Armor", | ||
| "bonus_armor": "Bonus Armor", | ||
| "health": "Health", | ||
| "mana": "Mana", | ||
| "mp5": "MP5", | ||
| "main_hand_dps": "Main Hand DPS", | ||
| "off_hand_dps": "Off Hand DPS", | ||
| "ranged_dps": "Ranged DPS", | ||
| "block": "Block", | ||
| "melee_speed_multiplier": "Melee Speed Multiplier", | ||
| "ranged_speed_multiplier": "Ranged Speed Multiplier", | ||
| "cast_speed_multiplier": "Cast Speed Multiplier", | ||
| "melee_haste": "Melee Haste", | ||
| "ranged_haste": "Ranged Haste", | ||
| "melee_hit": "Melee Hit", | ||
| "melee_crit": "Melee Crit" | ||
| } | ||
| }, | ||
| "sim": { | ||
| "title": "Mists of Pandaria {spec} {class} simulator", | ||
| "description": "{spec} {class} simulations for World of Warcraft® Mists of Pandaria Classic." | ||
| }, | ||
| "gear": { | ||
| "title": "Gear" | ||
| }, | ||
| "settings": { | ||
| "title": "Settings" | ||
| }, | ||
| "talents": { | ||
| "title": "Talents" | ||
| }, | ||
| "rotation": { | ||
| "title": "Rotation" | ||
| }, | ||
| "results": { | ||
| "title": "Results" | ||
| }, | ||
| "import": { | ||
| "title": "Import" | ||
| }, | ||
| "export": { | ||
| "title": "Export" | ||
| }, | ||
| "sidebar": { | ||
| "iterations": "Iterations", | ||
| "buttons": { | ||
| "simulate": "Simulate", | ||
| "stat_weights": "Stat Weights", | ||
| "suggest_reforges": "Suggest Reforges" | ||
| }, | ||
| "header": { | ||
| "title": "WoWSims - Mists of Pandaria", | ||
| "phase": "{{phase}} - {{status}}" | ||
| }, | ||
| "character_stats": { | ||
| "title": "Stats", | ||
| "melee_crit_cap": "Melee Crit Cap", | ||
| "tooltip": { | ||
| "base": "Base:", | ||
| "gear": "Gear:", | ||
| "talents": "Talents:", | ||
| "buffs": "Buffs:", | ||
| "consumes": "Consumes:", | ||
| "bonus": "Bonus:", | ||
| "total": "Total:", | ||
| "glancing": "Glancing:", | ||
| "suppression": "Suppression:", | ||
| "to_hit_cap": "To Hit Cap:", | ||
| "to_exp_cap": "To Exp Cap:", | ||
| "spec_offsets": "Spec Offsets:", | ||
| "final_crit_cap": "Final Crit Cap:", | ||
| "can_raise_by": "Can Raise By:" | ||
| }, | ||
| "crit_cap": { | ||
| "exact": "Exact", | ||
| "over_by": "Over by", | ||
| "under_by": "Under by" | ||
| }, | ||
| "bonus_prefix": "Bonus", | ||
| "points_suffix": "Points", | ||
| "percent_suffix": "%" | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If phases are just going to be a number then we actually dont need this right? We can just use the browser's Int.NumberFormat. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat.
If we use this entry I would suggest that we actually have this for example:
"1": "Phase 1 (T14)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh that's where you use it. We also use it in the Filter dropdown (I thought that's where you wanted this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which filter are you referring? xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Phases filter in the Gear picker popup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that will be later, I am doing BFS now and making sure all first level UI are localized