Rogue MoP Implementation

assets/database/leftover_db.json

@@ -1923,7 +1923,6 @@
 {"id":29993,"name":"Twinblade of the Phoenix","icon":"inv_sword_2h_blood_c_01","type":13,"weaponType":9,"handType":4,"gemSockets":[2,4,3],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,8,8,0,0,0,0,0,0,0,0],"weaponSpeed":3.6,"quality":4,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":98,"weaponDamageMin":505,"weaponDamageMax":759,"stats":{"2":53,"6":37,"12":110,"13":110},"ilvl":141}}},
 {"id":29994,"name":"Thalassian Wildercloak","icon":"inv_misc_cape_15","type":4,"armorType":1,"quality":4,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":53,"stats":{"1":28,"2":59,"17":267},"ilvl":138}}},
 {"id":29995,"name":"Leggings of Murderous Intent","icon":"inv_pants_leather_03","type":9,"armorType":2,"quality":4,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":95,"stats":{"1":46,"2":74,"6":37,"17":643},"ilvl":138}}},
-{"id":29996,"name":"Rod of the Sun King","icon":"inv_mace_48","type":13,"weaponType":4,"handType":2,"weaponSpeed":2.7,"quality":4,"unique":true,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":42,"weaponDamageMin":255,"weaponDamageMax":474,"stats":{"12":52,"13":52},"ilvl":141}}},
 {"id":29997,"name":"Band of the Ranger-General","icon":"inv_jewelry_ring_55","type":11,"quality":4,"unique":true,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":53,"stats":{"2":27,"5":18,"6":28,"12":56,"13":56},"ilvl":138}}},
 {"id":29998,"name":"Royal Gauntlets of Silvermoon","icon":"inv_gauntlets_29","type":7,"armorType":4,"gemSockets":[4,3],"socketBonus":[0,0,0,0,0,0,0,0,0,3,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":2,"sources":[{"drop":{"difficulty":1,"npcId":19622,"zoneId":3845}}],"scalingOptions":{"0":{"randPropPoints":71,"stats":{"0":22,"2":57,"9":34,"17":1003},"ilvl":138}}},
 {"id":29999,"name":"After Hours Pauldrons","icon":"inv_shoulder_11","type":3,"armorType":2,"quality":2,"scalingOptions":{"0":{"randPropPoints":38,"stats":{"1":28,"2":27,"5":7,"17":336},"ilvl":108}}},
@@ -11806,7 +11805,6 @@
 {"id":49979,"name":"Handguards of Winter's Respite","icon":"inv_gauntlets_83","type":7,"armorType":2,"gemSockets":[4,2],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,7,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lord Marrowgar"}}],"scalingOptions":{"0":{"randPropPoints":229,"stats":{"2":172,"3":104,"4":80,"7":64,"17":878},"ilvl":264}}},
 {"id":49980,"name":"Rusted Bonespike Pauldrons","icon":"inv_shoulder_117","type":3,"armorType":4,"gemSockets":[4,3],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,7,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lord Marrowgar"}}],"scalingOptions":{"0":{"randPropPoints":229,"stats":{"2":172,"3":104,"4":64,"6":80,"17":1978},"ilvl":264}}},
 {"id":49981,"name":"Fal'inrush, Defender of Quel'thalas","icon":"inv_weapon_crossbow_38","type":14,"rangedWeaponType":2,"weaponSpeed":3,"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"The Lich King"}}],"scalingOptions":{"0":{"randPropPoints":329,"weaponDamageMin":1445,"weaponDamageMax":2168,"stats":{"1":173,"2":260,"6":115,"7":115},"ilvl":271}}},
-{"id":49982,"name":"Heartpierce","icon":"inv_weapon_shortblade_103","type":13,"weaponType":2,"handType":2,"weaponSpeed":1.8,"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":132,"weaponDamageMin":621,"weaponDamageMax":933,"stats":{"1":47,"2":69},"ilvl":264}}},
 {"id":49983,"name":"Blood-Soaked Saronite Stompers","icon":"inv_boots_plate_12","type":10,"armorType":4,"gemSockets":[4,2],"socketBonus":[6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":229,"stats":{"0":104,"2":181,"6":80,"7":64,"17":1814},"ilvl":264}}},
 {"id":49985,"name":"Juggernaut Band","icon":"item_icecrownringd","type":11,"gemSockets":[2],"socketBonus":[0,0,6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":172,"stats":{"0":90,"2":124,"9":62,"10":48},"ilvl":264}}},
 {"id":49986,"name":"Broken Ram Skull Helm","icon":"inv_helmet_158","type":1,"armorType":4,"gemSockets":[1,2],"socketBonus":[0,0,12,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":5,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":308,"stats":{"0":123,"2":207,"5":74,"9":146,"17":2143},"ilvl":264}}},
@@ -12130,7 +12128,6 @@
 {"id":50638,"name":"Zod's Repeating Longbow","icon":"inv_weapon_bow_55","type":14,"rangedWeaponType":1,"gemSockets":[3],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,8,8,0,0,0,0,0,0,0,0],"weaponSpeed":2.8,"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":348,"weaponDamageMin":1253,"weaponDamageMax":2329,"stats":{"1":106,"2":183},"ilvl":277}}},
 {"id":50639,"name":"Blood-Soaked Saronite Stompers","icon":"inv_boots_plate_13","type":10,"armorType":4,"gemSockets":[4,3],"socketBonus":[6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":258,"stats":{"0":120,"2":203,"6":90,"7":74,"17":1900},"ilvl":277}}},
 {"id":50640,"name":"Broken Ram Skull Helm","icon":"inv_helmet_151","type":1,"armorType":4,"gemSockets":[1,2],"socketBonus":[0,0,12,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":348,"stats":{"0":139,"2":239,"5":85,"9":167,"17":2246},"ilvl":277}}},
-{"id":50641,"name":"Heartpierce","icon":"inv_weapon_shortblade_103","type":13,"weaponType":2,"handType":2,"gemSockets":[4],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,8,8,0,0,0,0,0,0,0,0],"weaponSpeed":1.8,"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":149,"weaponDamageMin":708,"weaponDamageMax":1063,"stats":{"1":48,"2":78},"ilvl":277}}},
 {"id":50642,"name":"Juggernaut Band","icon":"item_icecrownringd","type":11,"gemSockets":[2],"socketBonus":[0,0,6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":194,"stats":{"0":102,"2":141,"9":70,"10":54},"ilvl":277}}},
 {"id":50643,"name":"Shoulders of Mercy Killing","icon":"inv_shoulder_114","type":3,"armorType":1,"gemSockets":[3,2],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,7,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":258,"stats":{"2":193,"3":120,"5":74,"7":90,"17":901},"ilvl":277}}},
 {"id":50644,"name":"Ring of Maddening Whispers","icon":"inv_jewelry_ring_ahnqiraj_05","type":11,"gemSockets":[4],"socketBonus":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,5,0,0,0,0,0,0,0],"quality":4,"expansion":3,"sources":[{"drop":{"difficulty":6,"zoneId":4812,"otherName":"Lady Deathwhisper"}}],"scalingOptions":{"0":{"randPropPoints":194,"stats":{"2":145,"3":94,"4":68,"6":60},"ilvl":277}}},
@@ -14504,7 +14501,7 @@
 {"id":58183,"name":"Soul Casket","icon":"inv_misc_enggizmos_12","type":12,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":482,"stats":{"11":321},"ilvl":359}}},
 {"id":58184,"name":"Core of Ripeness","icon":"inv_misc_cat_trinket04","type":12,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":482,"stats":{"3":321},"ilvl":359}}},
 {"id":58185,"name":"Band of Bees","icon":"inv_misc_pearlring1","type":11,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":362,"stats":{"0":190,"2":286,"7":127,"11":127},"ilvl":359}}},
-{"id":58186,"name":"Skullcracker Ring","icon":"inv_jewelry_ring_47","type":11,"quality":3,"unique":true,"sources":[{"drop":{"difficulty":2,"npcId":105,"zoneId":5374,"otherName":"Rom'ogg Bonecrusher"}}],"scalingOptions":{"0":{"randPropPoints":320,"stats":{"1":168,"2":252,"6":112,"7":112},"ilvl":346}}},
+{"id":58186,"name":"Skullcracker Ring","icon":"inv_jewelry_ring_47","type":11,"quality":3,"unique":true,"sources":[{"drop":{"difficulty":1,"npcId":105,"zoneId":5374,"otherName":"Rom'ogg Bonecrusher"}}],"scalingOptions":{"0":{"randPropPoints":320,"stats":{"1":168,"2":252,"6":112,"7":112},"ilvl":346}}},
 {"id":58187,"name":"Ring of the Battle Anthem","icon":"inv_jewelry_ring_82","type":11,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":362,"stats":{"0":190,"2":286,"9":127,"11":127},"ilvl":359}}},
 {"id":58188,"name":"Band of Secret Names","icon":"inv_misc_diamondring1","type":11,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":362,"stats":{"2":286,"3":190,"6":127,"7":127},"ilvl":359}}},
 {"id":58189,"name":"Twined Band of Flowers","icon":"inv_misc_pearlring1","type":11,"quality":4,"unique":true,"scalingOptions":{"0":{"randPropPoints":362,"stats":{"2":286,"3":190,"4":127,"11":127},"ilvl":359}}},

proto/rogue.proto

@@ -78,20 +78,16 @@ enum RogueMinorGlyph {
 
 message RogueOptions {
 	UnitReference tricks_of_the_trade_target = 1;
-	enum PoisonImbue {
+	enum PoisonOptions {
 		NoPoison = 0;
-		InstantPoison = 1;
-		DeadlyPoison = 2;
-		WoundPoison = 3;
+		DeadlyPoison = 1;
+		WoundPoison = 2;
 	}
-	PoisonImbue mh_imbue = 2;
-	PoisonImbue oh_imbue = 3;
-	PoisonImbue th_imbue = 4;
-	int32 starting_overkill_duration = 5;
-	bool apply_poisons_manually = 6;
-	bool assume_bleed_active = 7;
-	float vanish_break_time = 8;
-	int32 starting_combo_points = 9;
+	PoisonOptions lethal_poison = 2;
+	int32 starting_overkill_duration = 3;
+	bool apply_poisons_manually = 4;
+	float vanish_break_time = 5;
+	int32 starting_combo_points = 6;
 }
 
 message AssassinationRogue {

sim/common/mop/enchants_auto_gen.go

@@ -1,17 +1,17 @@
 package mop
 
 import (
+	"github.com/wowsims/mop/sim/common/shared"
 	"github.com/wowsims/mop/sim/core"
- 	"github.com/wowsims/mop/sim/common/shared"
 )
 
 func RegisterAllEnchants() {
 
 	// Enchants
-	
+
 	// Permanently attaches Lord Blastington's special scope to a ranged weapon, sometimes increasing Agility
 	// by 1800 for 10s when dealing damage with ranged attacks.
-	// 
+	//
 	// Attaching this scope to a ranged weapon causes it to become soulbound.
 	shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
 		Name:      "Lord Blastington's Scope of Doom",
@@ -21,10 +21,10 @@ func RegisterAllEnchants() {
 		Outcome:   core.OutcomeLanded,
 		Harmful:   true,
 	})
-	
+
 	// Permanently attaches a mirrored scope to a ranged weapon, sometimes increases critical strike by 900 for
 	// 10s when dealing damage with ranged attacks.
-	// 
+	//
 	// Attaching this scope to a ranged weapon causes it to become soulbound.
 	shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
 		Name:      "Mirror Scope",
@@ -34,10 +34,10 @@ func RegisterAllEnchants() {
 		Outcome:   core.OutcomeLanded,
 		Harmful:   true,
 	})
-	
+
 	// Embroiders a subtle pattern of light into your cloak, giving you a chance to increase your Intellect by
 	// 2000 for 15s when casting a spell.
-	// 
+	//
 	// Embroidering your cloak will cause it to become soulbound and requires the Tailoring profession to remain
 	// active.
 	shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
@@ -48,10 +48,10 @@ func RegisterAllEnchants() {
 		Outcome:   core.OutcomeLanded,
 		Harmful:   true,
 	})
-	
+
 	// Embroiders a magical pattern into your cloak, giving you a chance to increase your Spirit by 3000 for
 	// 15s when you cast a spell.
-	// 
+	//
 	// Embroidering your cloak will cause it to become soulbound and requires the Tailoring profession to remain
 	// active.
 	shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
@@ -62,10 +62,10 @@ func RegisterAllEnchants() {
 		Outcome:   core.OutcomeLanded,
 		Harmful:   true,
 	})
-	
+
 	// Embroiders a magical pattern into your cloak, causing your damaging melee and ranged attacks to sometimes
 	// increase your attack power by 4000 for 15s.
-	// 
+	//
 	// Embroidering your cloak will cause it to become soulbound and requires the Tailoring profession to remain
 	// active.
 	shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
@@ -76,4 +76,4 @@ func RegisterAllEnchants() {
 		Outcome:   core.OutcomeLanded,
 		Harmful:   true,
 	})
-}
+}