[Feature] Raid buffs & debuffs #58

ToxicKevinFerm · 2025-05-04T03:03:39Z

No description provided.

1337LutZ · 2025-05-04T11:54:37Z

ui/core/components/character_stats.tsx

-		if (debuffs.criticalMass || debuffs.shadowAndFlame) {
-			debuffStats = debuffStats.addPseudoStat(PseudoStat.PseudoStatSpellCritPercent, 5);
-		}
+		// const debuffs = this.player.sim.raid.getDebuffs();


These comments can just be removed

If there are no more debuffs that boost character stats against that target in MoP, then we should remove this method entirely and also remove the "Debuffs" part of the character stats breakdown.

sim/core/debuffs.go

1337LutZ

Found a bug in the stacking Armor reduction

1337LutZ

Fixed the Armor bug & some UI input state bugs

NerdEgghead

Looks like there are also test failures to resolve.

sim/core/debuffs.go

NerdEgghead · 2025-05-05T13:10:06Z

sim/core/debuffs.go

+func MortalWoundsArua(target *Unit) *Aura {
+	return majorHealingReductionAura(target, "Mortal Wounds", 115804, 0.25)
 }


Typo, should be MortalWoundsAura()

True, fixed

NerdEgghead · 2025-05-05T13:15:32Z

sim/core/debuffs.go

+func ScheduledMajorArmorAura(aura *Aura, options PeriodicActionOptions, raid *proto.Raid) {
+	aura.OnReset = func(aura *Aura, sim *Simulation) {
+		aura.Duration = NeverExpires
+		StartPeriodicAction(sim, options)
+	}
 }


I don't think this is needed anymore?

NerdEgghead · 2025-05-05T13:18:03Z

sim/core/exclusive_effect_test.go

 	// Trauma in this case should *never* be overwritten
 	// as its duration from 'MakePermanent' should make it non overwritable by 1 min duration mangles


Update comment to reflect the new test cases being used.

NerdEgghead · 2025-05-05T13:19:11Z

sim/core/exclusive_effect_test.go


 	// In this case mangle should overwrite trauma as mangle will give a greater duration


Update comment here as well.

NerdEgghead · 2025-05-05T13:23:32Z

ui/core/components/character_stats.tsx

-		if (debuffs.criticalMass || debuffs.shadowAndFlame) {
-			debuffStats = debuffStats.addPseudoStat(PseudoStat.PseudoStatSpellCritPercent, 5);
-		}
+		// const debuffs = this.player.sim.raid.getDebuffs();


If there are no more debuffs that boost character stats against that target in MoP, then we should remove this method entirely and also remove the "Debuffs" part of the character stats breakdown.

NerdEgghead · 2025-05-05T13:26:45Z

ui/core/components/individual_sim_ui/consumes_picker.tsx

 	private updateRow(rowElem: Element, pickers: (IconPicker<Player<any>, any> | IconEnumPicker<Player<any>, any>)[]) {
+		console.log('Updating consumes row', pickers);


Put this behind an isDevMode() check.

Removed it since its not needed

ui/core/components/inputs/consumables.ts

Raid buffs

NerdEgghead

Looks good overall, just needs some cleanup.

NerdEgghead · 2025-05-06T06:06:10Z

proto/common.proto

+	int32 mana_tide_totem_count   = 35;
+  }


Need to add count fields for Skull Banner and Stormlash Totem as well.

NerdEgghead · 2025-05-06T06:22:17Z

sim/core/buffs.go

+func CommandingShoutAura(unit *Unit, asExternal bool, withGlyph bool) *Aura {
+	baseAura := makeExclusiveBuff(unit, BuffConfig{
+		"Commanding Shout",
+		ActionID{SpellID: 469},
 		[]StatConfig{
-			{stats.AttackPower, 1.2, true},
+			{stats.AttackPower, 1.1, true},
 			{stats.RangedAttackPower, 1.1, true},
-			{stats.MP5, 326, false},
+			{stats.Stamina, 1.1, true},
 		}})


Does Commanding Shout buff both AP and Stam in MoP?

NerdEgghead · 2025-05-06T06:23:57Z

sim/core/buffs.go

+func UnleashedRageAura(u *Unit) *Aura {
+	return makeExclusiveBuff(u, BuffConfig{"Unleashed Rage", ActionID{SpellID: 30809}, []StatConfig{{stats.AttackPower, 1.2, true}, {stats.RangedAttackPower, 1.1, true}}})
 }


Is different multipliers for melee vs. ranged AP here intended?

NerdEgghead · 2025-05-06T06:36:57Z

sim/core/buffs.go

-var ManaTideTotemActionID = ActionID{SpellID: 16190}
-var ManaTideTotemAuraTag = "ManaTideTotem"
-
-const ManaTideTotemDuration = time.Second * 12
-const ManaTideTotemCD = time.Minute * 5
-
-func registerManaTideTotemCD(agent Agent, numManaTideTotems int32) {


Did you intend to delete this? The proto field is still present.

Mana Tide works differently in MoP, I've decided to leave it to be implemented later since it's more complex. It gives 200% of the casters Spirit, so we'd need an input for that etc.

I added it back since it looks like it worked the same in cata (wrongly?)

NerdEgghead · 2025-05-06T06:39:51Z

sim/death_knight/blood/blood.go

-	healingModel := options.HealingModel
-	if healingModel != nil {
-		if healingModel.InspirationUptime > 0.0 {
-			core.ApplyInspiration(&bdk.Unit, healingModel.InspirationUptime)
-		}
-	}


If Inspiration / Ancestral Fortitude or equivalents no longer exist in MoP, then the inspiration_uptime field should also be deleted from the HealingModel proto.

NerdEgghead · 2025-05-06T07:24:14Z

ui/paladin/retribution/sim.ts

 		individualBuffs: IndividualBuffs.create({
 			communion: true,
 		}),


IndividualBuffs also needs to be cleaned out if Replenishment is no longer a thing in MoP.

NerdEgghead · 2025-05-06T07:27:59Z

ui/priest/shadow/presets.ts

 export const DefaultIndividualBuffs = IndividualBuffs.create({
 	vampiricTouch: true,
 	darkIntent: true,
 });


darkIntent also needs to be removed from IndividualBuffs in MoP

NerdEgghead · 2025-05-06T07:32:28Z

ui/raid/raid_stats.tsx

+							label: 'Terrifying Roar',
+							actionId: ActionId.fromSpellId(90309),
+							playerData: playerClass(Class.ClassDruid),


I think you meant Hunter here.

NerdEgghead · 2025-05-06T07:33:54Z

ui/raid/raid_stats.tsx

+							label: 'Roar of Courage',
+							actionId: ActionId.fromSpellId(93435),
+							playerData: playerClass(Class.ClassWarrior),


Should be Hunter as well

NerdEgghead · 2025-05-06T07:36:10Z

ui/raid/raid_stats.tsx

+							label: 'Qiraji Fortitude',
+							actionId: ActionId.fromSpellId(90364),
+							playerData: playerClass(Class.ClassDruid),


Should be Hunter as well

NerdEgghead · 2025-05-07T09:23:31Z

proto/common.proto

+	bool commanding_shout         = 4;  // Warriors
+


Group this with the other Stamina buffs.

NerdEgghead · 2025-05-07T09:25:10Z

proto/common.proto


 	// Major Mana Replenishment


Name this section "Raid Cooldowns" for generality.

NerdEgghead · 2025-05-07T09:33:28Z

proto/common.proto

Also need to delete vampiric_touch, enduring_winter, soul_leach, revitalize, communion, power_infusion_count, focus_magic, and dark_intent from IndividualBuffs.

NerdEgghead · 2025-05-07T09:36:38Z

sim/core/buffs.go

-		CommandingShoutAura(unit, true, false)
+		CommandingShoutAura(u, false)


Should be true rather than false.

NerdEgghead · 2025-05-07T09:40:35Z

sim/core/buffs.go

 func HornOfWinterAura(unit *Unit, asExternal bool, withGlyph bool) *Aura {
 	baseAura := makeExclusiveBuff(unit, BuffConfig{


Remove the withGlyph input if it's no longer used.

NerdEgghead · 2025-05-07T09:41:10Z

sim/core/buffs.go

 func BattleShoutAura(unit *Unit, asExternal bool, withGlyph bool) *Aura {
 	baseAura := makeExclusiveBuff(unit, BuffConfig{


Remove the withGlyph input if it's no longer used.

NerdEgghead · 2025-05-07T09:42:59Z

sim/core/buffs.go

+func UnleashedRageAura(u *Unit) *Aura {
+	return makeExclusiveBuff(u, BuffConfig{"Unleashed Rage", ActionID{SpellID: 30809}, []StatConfig{{stats.AttackPower, 1.1, true}, {stats.RangedAttackPower, 1.1, true}}})
 }


This got changed from an AP buff to a Haste buff in MoP I believe.

NerdEgghead · 2025-05-07T10:09:51Z

ui/raid/raid_stats.tsx

+						{
+							label: 'Commanding Shout',
+							actionId: ActionId.fromSpellId(469),
+							playerData: playerClass(Class.ClassWarrior),
+						},


This should be in the 'Stamina' section.

neteyesking added 3 commits May 3, 2025 22:02

Use MoP debuffs

d9b9fd1

Update debuff pickers

c9d416c

make everything run

874acaf

github-actions bot added Death Knight Druid Hunter Mage Paladin Priest Rogue Shaman Warlock Warrior Monk labels May 4, 2025

neteyesking added 4 commits May 3, 2025 22:09

Fix common.proto comments

def6f3a

Fix some tests

c332536

Fix sunder test

653c69c

Tests update again

37d2d79

1337LutZ reviewed May 4, 2025

View reviewed changes

1337LutZ approved these changes May 4, 2025

View reviewed changes

Update armor test

2f6c4bc

1337LutZ reviewed May 4, 2025

View reviewed changes

sim/core/debuffs.go Show resolved Hide resolved

1337LutZ requested changes May 4, 2025

View reviewed changes

Various consume / input toggle fixes

6cde777

1337LutZ approved these changes May 4, 2025

View reviewed changes

1337LutZ and others added 3 commits May 4, 2025 23:00

Fix proper stacks setting

108f3af

Make Spell Damage Taken a single aura

7f3f298

First v

db55bed

NerdEgghead requested changes May 5, 2025

View reviewed changes

Remove unused

ba23832

neteyesking and others added 7 commits May 5, 2025 09:07

Address PR comments

1f3f28d

Remove

2f2c80e

Update raid buffs to MoP

78ef89a

Delete old presets

c727ce1

Add faction

8916abe

Remove faction

fbdba9c

Merge pull request #61 from wowsims/raid-buffs

304fa62

Raid buffs

ToxicKevinFerm changed the title ~~[Feature] Raid debuffs~~ [Feature] Raid buffs & debuffs May 5, 2025

neteyesking added 3 commits May 5, 2025 13:42

Merge branch 'master' into raid-debuffs

5887699

Remvoe stamina from all stats

cfbad64

Add missing buffs

884ad9c

NerdEgghead requested changes May 6, 2025

View reviewed changes

1337LutZ mentioned this pull request May 6, 2025

Challenge Mode toggle #57

Merged

neteyesking added 4 commits May 6, 2025 11:07

Fix PR notes

49a97ee

Add back mana tide

8a715f9

Remove commanding shout from ap

1c9752a

Remove dark intent uptime

60f213c

ToxicKevinFerm requested a review from NerdEgghead May 6, 2025 23:21

NerdEgghead requested changes May 7, 2025

View reviewed changes

neteyesking added 3 commits May 7, 2025 12:56

Fix last pr notes

92343fb

Fix compile

67f5571

Remove PI etc from frontend

0564bae

ToxicKevinFerm merged commit fb60f5b into master May 7, 2025
2 checks passed

InDebt mentioned this pull request May 11, 2025

[Settings] Implement Raid Buffs for MoP #42

Closed

57 tasks

		// Trauma in this case should never be overwritten
		// as its duration from 'MakePermanent' should make it non overwritable by 1 min duration mangles


		// In this case mangle should overwrite trauma as mangle will give a greater duration

		private updateRow(rowElem: Element, pickers: (IconPicker<Player<any>, any> \| IconEnumPicker<Player<any>, any>)[]) {
		console.log('Updating consumes row', pickers);

		CommandingShoutAura(unit, true, false)
		CommandingShoutAura(u, false)

		func HornOfWinterAura(unit Unit, asExternal bool, withGlyph bool) Aura {
		baseAura := makeExclusiveBuff(unit, BuffConfig{

		func BattleShoutAura(unit Unit, asExternal bool, withGlyph bool) Aura {
		baseAura := makeExclusiveBuff(unit, BuffConfig{

[Feature] Raid buffs & debuffs #58

[Feature] Raid buffs & debuffs #58

Uh oh!

Conversation

ToxicKevinFerm commented May 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

1337LutZ left a comment

Choose a reason for hiding this comment

Uh oh!

1337LutZ left a comment

Choose a reason for hiding this comment

Uh oh!

NerdEgghead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NerdEgghead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment