Balance druid initial implementation #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no longer proc it, moved some code to the balance package
1337LutZ
reviewed
May 6, 2025
1337LutZ
reviewed
May 6, 2025
… agnostic talents
…sions to their auras' OnSpellHitTaken
1337LutZ
reviewed
May 7, 2025
1337LutZ
reviewed
May 7, 2025
1337LutZ
reviewed
May 7, 2025
1337LutZ
reviewed
May 7, 2025
…s handling in eclipse
…ing channel if Eclipse is activated
NerdEgghead
requested changes
Jun 11, 2025
NerdEgghead
left a comment
NerdEgghead
left a comment
There was a problem hiding this comment.
Looks like you also have to resolve some merge conflicts.
Comment on lines
+94
to
+95
| baselineEclipsePct := 0.15 | ||
| initialEclipseMasteryBonus := getEclipseMasteryBonus(moonkin.GetMasteryPoints()) |
There was a problem hiding this comment.
It looks like getEclipseMasteryBonus() will already include the contribution from baselineEclipsePct?
Member
Author
There was a problem hiding this comment.
balance has an additional 15% over the 8 mastery baseline points. In cata it was 16 (base mastery) + 15, now its 15+15 and I do need to update that calculation. Otherwise it is correct.
Comment on lines
138
to
+139
| OnExpire: func(aura *core.Aura, sim *core.Simulation) { | ||
| baselineEclipsePct = 0.15 |
There was a problem hiding this comment.
I think this should actually be 0 if I'm understanding the code correctly.
…Stars penalty when multidotting, Nature's Swiftness available for all specs + Glyph of Healing Touch
Deploying mop with
|
| Latest commit: |
2b83c10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0066af9.mop-617.pages.dev |
| Branch Preview URL: | https://fix-balance-druid.mop-617.pages.dev |
On branch fix/balance-druid Changes to be committed: new file: sim/core/TestProtoVersioning.results modified: sim/druid/balance/TestBalance.results modified: sim/druid/balance/passives.go
NerdEgghead
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.