Skip to content

Conversation

@InDebt
Copy link

@InDebt InDebt commented May 13, 2025

  • Ranged weapons are now part of the main hand gear picker
  • Weapons will still be treated as ranged weapons on the backend
  • This includes also removing hunter deadzone

fixes #76

* Ranged weapons are now part of the main hand gear picker
* Weapons will still be treated as ranged weapons on the backend
* This includes also removing hunter deadzone
@1337LutZ
Copy link

1337LutZ commented May 13, 2025

I am missing changes to item_swaps.go that also references the Ranged Item Slot 🤔

Or... I guess it's because the slot technically still exists?

@InDebt
Copy link
Author

InDebt commented May 13, 2025

Uhh yeah I'll go thorugh that code. Technically I've removed the ranged slot from the UI. But I'll have to make sure the item swap code properly handles ranged weapons in the main slot.. if we need it ig 😁

@NerdEgghead
Copy link

I am missing changes to item_swaps.go that also references the Ranged Item Slot 🤔

Or... I guess it's because the slot technically still exists?

If the slot is gone in-game then we should remove it from the proto.ItemSlot enum entirely. That will automatically catch any stray references to it in the codebase at build time.

@InDebt
Copy link
Author

InDebt commented May 15, 2025

Alright I removed the Item Slot completly. Only the ItemType Ranged remain.
Also validated that item swap works properly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this file in the MoP repo? I think @ToxicKevinFerm was able to delete it from the Cata repo as part of the item DB PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wowsims/cata/blob/master/tools/database/wowhead_tooltips.go#L16 - right now it's still in there, but it#s only used to parse zones from Atlas Loot as far as I can see 🤔

It should be possible to remove that however as I can only find it being used to read Zone names. Which we can now actually lookup through the SQLLite DB here: https://wago.tools/db2/AreaTable?build=5.5.0.60700&filter%5BID%5D=exact%3A206&page=1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a sperate PR #90 for that

Copy link

@NerdEgghead NerdEgghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added some final comments.

@InDebt
Copy link
Author

InDebt commented May 16, 2025

Added the two racials and will create an Issue to look over all racials as there might be others we have to update.

@InDebt InDebt merged commit f41e403 into master May 16, 2025
2 checks passed
@1337LutZ 1337LutZ deleted the fix/ranged-slot branch December 6, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI][Core] Remove Ranged Weapon Slot

4 participants