-
Notifications
You must be signed in to change notification settings - Fork 38
[Feature] Remove Ranged Weapon Slot from UI #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Ranged weapons are now part of the main hand gear picker * Weapons will still be treated as ranged weapons on the backend * This includes also removing hunter deadzone
|
I am missing changes to Or... I guess it's because the slot technically still exists? |
|
Uhh yeah I'll go thorugh that code. Technically I've removed the ranged slot from the UI. But I'll have to make sure the item swap code properly handles ranged weapons in the main slot.. if we need it ig 😁 |
If the slot is gone in-game then we should remove it from the proto.ItemSlot enum entirely. That will automatically catch any stray references to it in the codebase at build time. |
|
Alright I removed the Item Slot completly. Only the ItemType |
tools/database/wowhead_tooltips.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need this file in the MoP repo? I think @ToxicKevinFerm was able to delete it from the Cata repo as part of the item DB PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/wowsims/cata/blob/master/tools/database/wowhead_tooltips.go#L16 - right now it's still in there, but it#s only used to parse zones from Atlas Loot as far as I can see 🤔
It should be possible to remove that however as I can only find it being used to read Zone names. Which we can now actually lookup through the SQLLite DB here: https://wago.tools/db2/AreaTable?build=5.5.0.60700&filter%5BID%5D=exact%3A206&page=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a sperate PR #90 for that
NerdEgghead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added some final comments.
|
Added the two racials and will create an Issue to look over all racials as there might be others we have to update. |
fixes #76