Replace tablesorter lib with custom sorter #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337LutZ
reviewed
Apr 3, 2025
ui/core/components/detailed_results/metrics_table/metrics_table.tsx
Outdated
Show resolved
Hide resolved
1337LutZ
reviewed
Apr 3, 2025
ui/core/components/detailed_results/metrics_table/table_sorter.ts
Outdated
Show resolved
Hide resolved
1337LutZ
reviewed
Apr 3, 2025
ui/core/components/detailed_results/metrics_table/table_sorter.ts
Outdated
Show resolved
Hide resolved
1337LutZ
reviewed
Apr 3, 2025
ui/core/components/detailed_results/metrics_table/table_sorter.ts
Outdated
Show resolved
Hide resolved
1337LutZ
reviewed
Apr 3, 2025
ui/core/components/detailed_results/metrics_table/table_sorter.ts
Outdated
Show resolved
Hide resolved
1337LutZ
reviewed
Apr 3, 2025
|
|
||
| this.tableElem = this.rootElem.getElementsByClassName('metrics-table')[0] as HTMLTableSectionElement; | ||
| this.bodyElem = this.rootElem.getElementsByClassName('metrics-table-body')[0] as HTMLElement; | ||
| this.tableElem = this.rootElem.querySelector('.metrics-table') as HTMLTableElement; |
Contributor
There was a problem hiding this comment.
You can pass the HTMLTableElement as a generic: .querySelector<HTMLTableElement>()! and then use ! to tell TS you are sure this is never undefined. Cleaner than typecasting (i tried to fix this in a lot of legacy components)
Contributor
Author
There was a problem hiding this comment.
lol used typecasting because it's done everywhere else like that. Should I just regex replace all of them then? :D
Contributor
There was a problem hiding this comment.
I tried to get rid of it where I did major refactors 😅😂 feel free to run a find replace regex tbh 👌🫠
1337LutZ
reviewed
Apr 3, 2025
This was referenced Apr 10, 2025
Collaborator
|
Gonna go ahead and merge this 👍 Thanks @FelixPflaum ! I opened issue in the Classic, Cata, and Wrath repos as well to track porting it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.