Skip to content

Phase 8 - Implement Starter's Pistol weapon effect #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 2 commits into from
Apr 4, 2025
Merged

Phase 8 - Implement Starter's Pistol weapon effect #1436

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ca78e
Implement starters pistol weapon effect
fynnen Apr 4, 2025
4e0f0f8
removed action id from trigger aura
fynnen Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions sim/common/sod/item_effects/phase_8.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const (
Caladbolg = 238961
WillOfTheMountain = 239060
HighCommandersGuard = 240841
StartersPistol = 240843
LightfistHammer = 240850
Regicide = 240851
CrimsonCleaver = 240852
Expand Down Expand Up @@ -1039,6 +1040,31 @@ func init() {
character.ItemSwap.RegisterActive(SoporificBlade)
})

// https://www.wowhead.com/classic-ptr/item=240843/starters-pistol
// Equip: Firing a regular ranged attack at a target prepares you for battle, increasing your Defense by 20 and melee attack speed by 10% for 15 sec.
core.NewItemEffect(StartersPistol, func(agent core.Agent) {
character := agent.GetCharacter()

buffAura := character.RegisterAura(core.Aura{
ActionID: core.ActionID{SpellID: 1231266},
Label: "En Garde!",
Duration: time.Second * 15,
}).AttachStatBuff(stats.Defense, 20).AttachMultiplyMeleeSpeed(&character.Unit, 1.10)

triggerAura := core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
ActionID: core.ActionID{SpellID: 1231267},
Copy link
Collaborator

@kayla-glick kayla-glick Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 we don't really need to add action IDs to most triggers like this. It just ends up adding bloat in the UI

Name: "En Garde!",
Callback: core.CallbackOnCastComplete,
ProcMask: core.ProcMaskRangedAuto,
ProcChance: 1,
Handler: func(sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
buffAura.Activate(sim)
},
})

character.ItemSwap.RegisterProc(StartersPistol, triggerAura)
})

// https://www.wowhead.com/classic-ptr/item=241068/stiltzs-standard
// Use: Throw down the Standard of Stiltz, increasing the maximum health of all nearby allies by 1000 for 20 sec. (2 Min Cooldown)
core.NewSimpleStatDefensiveTrinketEffect(StiltzsStandard, stats.Stats{stats.Health: 1000}, time.Second*20, time.Minute*2)
Expand Down
Loading