Skip to content

[Prot] Holy Shield fixes #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hillerstorm merged 1 commit into from
Apr 4, 2025
Merged

[Prot] Holy Shield fixes #1439

hillerstorm merged 1 commit into from
Apr 4, 2025

Conversation

@hillerstorm
Copy link
Contributor

@hillerstorm hillerstorm commented Apr 4, 2025

  • Regular Holy Shield should be binary (hit / resist) and not able to crit
  • Radiant Defender (6pc T1) should make HS able to crit but also partial resist
    • This version also uses a separate spellID

@hillerstorm hillerstorm merged commit cacb893 into wowsims:master Apr 4, 2025
2 checks passed
@hillerstorm hillerstorm deleted the holy_shield_hitcheck branch April 4, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hillerstorm