spellmod mortal shots #1456
Merged
spellmod mortal shots #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
reviewed
May 1, 2025
sim/hunter/hunter.go
Outdated
| }, | ||
| } | ||
| hunter.AutoAttacks.RangedConfig().CritDamageBonus = hunter.mortalShots() | ||
| hunter.AutoAttacks.RangedConfig().CritDamageBonus = 0.06 * float64(hunter.Talents.MortalShots) |
Collaborator
There was a problem hiding this comment.
Can we move this to within the mortal shots talent code?
JJwang11
force-pushed
the
mortal_shot_fixes
branch
from
eeb1073 to
8ff07f3
Compare
kayla-glick
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed mortal shots to spellmod implementation, which will also fix carve + volley along the way
fun fact: for some reason someone added 1% extra crit to chimera serpent