Skip to content

Conversation

@JJwang11
Copy link
Contributor

@JJwang11 JJwang11 commented May 3, 2025

Logs confirm:

  • 9 second buff duration, AoE every 1.5 seconds (First tick is 1.5 seconds after buff is obtained)
  • Can use abilities during it
  • Can proc Weapon Enchants (03:12.533 Bladestorm hit, 03:12.533 Righteous Inquisition Refresh, no other hits)
  • Can proc itself on last Bladestorm tick after 8 sec ICD (03:12.533 Bladestorm hit, 03:12.532 Bladestorm Buff is removed and Applied)
  • If Bladestorm buff is refreshed while active, the next tick is still 1.5 seconds after refresh (03:03.525 Bladestorm is refreshed, 03:02.437 -> 03:05.084 for next Bladestorm tick)
  • Can store + proc extra attacks (00:34.322 Bladestorm fades, 0.34.953 Double Melee removing 2 Wild Strike stacks), maybe there is retry timer? Need to also set max stored attacks for Hunter at 2.

There is currently a bug with this implementation where sometimes AutoAttack does not turn back on after Bladestorm fades. Not sure where it is.

Comment on lines 815 to 816
character.AutoAttacks.EnableAutoSwing(sim)
channelSpell.AOEDot().Cancel(sim)
whirlwindSpell.AOEDot().Cancel(sim)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you mentioned it was sometimes not starting to attack again. Does swapping the order of these fix that?

@kayla-glick kayla-glick merged commit eaf8faa into wowsims:master May 6, 2025
1 check passed
@JJwang11 JJwang11 mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants