Skip to content

Add Regicide aura for APL usage #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catszeid merged 3 commits into from
Jun 30, 2025
Merged

Add Regicide aura for APL usage #1482

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bf86cc
Add Regicide aura for APL usage
catszeid Jun 29, 2025
0b79437
Update cast condition
catszeid Jun 29, 2025
cf9db8e
Update Regicide to trigger on the 20th stack
catszeid Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sim/warrior/items.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,8 @@ func (warrior *Warrior) ApplyRegicideWarriorEffect(itemID int32, aura *core.Aura
Duration: time.Second * 15,
})
})
// Regicide aura for APL use on trigger from stacks
regicideAura := warrior.NewTemporaryStatsAura("Regicide", core.ActionID{SpellID: 1231436}, stats.Stats{}, 10*time.Second)

executeDamageMod := warrior.AddDynamicMod(core.SpellModConfig{
Kind: core.SpellMod_DamageDone_Pct,
Expand All @@ -301,6 +303,7 @@ func (warrior *Warrior) ApplyRegicideWarriorEffect(itemID int32, aura *core.Aura
ClassSpellMask: ClassSpellMask_WarriorExecute,
Handler: func(sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
debuffAuras.Get(result.Target).Deactivate(sim)
regicideAura.Deactivate(sim)
},
})
warrior.ItemSwap.RegisterProc(itemID, consumptionTrigger)
Expand All @@ -315,13 +318,18 @@ func (warrior *Warrior) ApplyRegicideWarriorEffect(itemID int32, aura *core.Aura
Handler: func(sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
debuff := debuffAuras.Get(result.Target)
debuff.Activate(sim)
// Activate aura for APL usage when effect is triggered
// Implementation of cast condition is below in 'ApplyOnInit'
if debuff.GetStacks() == 20 {
regicideAura.Activate(sim)
}
if debuff.MaxStacks > 0 {
debuff.AddStack(sim)
}
},
}).ApplyOnInit(func(aura *core.Aura, sim *core.Simulation) {
warrior.Execute.ApplyExtraCastCondition(func(sim *core.Simulation, target *core.Unit) bool {
return debuffAuras[target.Index].IsActive() && debuffAuras[target.Index].GetStacks() == 20
return debuffAuras[target.Index].IsActive() && debuffAuras[target.Index].GetStacks() == 20 && regicideAura.IsActive()
})
})
}
Expand Down
Loading