-
Notifications
You must be signed in to change notification settings - Fork 4
Fix DB Gen for Talents and Consumables #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| AllHitRating | ||
| AllCritRating | ||
| AllHasteRating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these or could we get away with just using the other stats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required as far as I could tell due to our structure on tools/database/dbc/maps.go.
A lot of Physical gear provides AllHit/AllCrit/AllHaste (applies to Physical and Spell), but that function can only return a single rating stat. We can't just ignore the Spell component as some Physical classes still have Spells (Shaman shocks, Rogue poisons, maybe others?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another indirect benefit of this is for said classes, they can EP weight on AllHitRating which greatly improves the UI experience for stat weights. In past iterations, we've had to do really jank solutions that made it difficult to visually evaluate the value of 1 hit rating on our gear, like relying on the value of 1 complete melee/spell hit percent, or telling users in class discords they have to add the melee and spell hit rating EP together.
No description provided.