Skip to content

Conversation

@TheBackstabi
Copy link

No description provided.

Comment on lines +47 to +49
AllHitRating
AllCritRating
AllHasteRating

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these or could we get away with just using the other stats?

Copy link
Author

@TheBackstabi TheBackstabi Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required as far as I could tell due to our structure on tools/database/dbc/maps.go.

A lot of Physical gear provides AllHit/AllCrit/AllHaste (applies to Physical and Spell), but that function can only return a single rating stat. We can't just ignore the Spell component as some Physical classes still have Spells (Shaman shocks, Rogue poisons, maybe others?)

Copy link
Author

@TheBackstabi TheBackstabi Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another indirect benefit of this is for said classes, they can EP weight on AllHitRating which greatly improves the UI experience for stat weights. In past iterations, we've had to do really jank solutions that made it difficult to visually evaluate the value of 1 hit rating on our gear, like relying on the value of 1 complete melee/spell hit percent, or telling users in class discords they have to add the melee and spell hit rating EP together.

@TheBackstabi TheBackstabi merged commit e27aca2 into master Nov 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants