Skip to content
This repository was archived by the owner on Apr 2, 2020. It is now read-only.

Add parse_oembeds() method to Shortcode class #153

Open
goldenapples wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add parse_oembeds() method to Shortcode class #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c8843
Add `parse_oembeds` method to Shortcode class
goldenapples Nov 17, 2015
619a330
Fix PHPCS issue
goldenapples Nov 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 40 additions & 26 deletions inc/shortcodes/class-facebook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@

class Facebook extends Shortcode {

// Our matching URL patterns for Facebook
private static $url_patterns = array(
'#https?://(www)?\.facebook\.com/[^/]+/posts/[\d]+#',
'#https?://(www)?\.facebook\.com\/video\.php\?v=[\d]+#',
'#https?:\/\/www?\.facebook\.com\/+.*?\/videos\/[\d]+\/#',
'#https?://(www)?\.facebook\.com\/permalink\.php\?story_fbid=[\d]+&id=[\d]+#',
'#https?:\/\/www?\.facebook\.com\/.*?\/photos\/([^/]+)/([\d])+/#',
'#https?:\/\/www?\.facebook\.com\/.*?\/videos\/([^/]+)/([\d])+/#',
'#https?:\/\/www?\.facebook\.com\/groups\/([\d])+\/permalink/([\d])+/?#',
);

public static function get_shortcode_ui_args() {
return array(
'label' => esc_html__( 'Facebook', 'shortcake-bakery' ),
Expand Down Expand Up @@ -52,29 +63,43 @@ public static function action_wp_footer() {

public static function reversal( $content ) {

if ( false === stripos( $content, '<script' ) ) {
return $content;
}
if ( false !== stripos( $content, '<script' ) ) {

/* Pattern for normal Facebook embeds */
if ( preg_match_all( '#<div id="fb-root"></div><script>[^<]+</script><div class="fb-post" [^>]+href=[\'\"]([^\'\"]+)[\'\"].+</div>(</div>)?#', $content, $matches ) ) {
$replacements = array();
$shortcode_tag = self::get_shortcode_tag();
foreach ( $matches[0] as $key => $value ) {
$replacements[ $value ] = '[' . $shortcode_tag . ' url="' . esc_url_raw( $matches[1][ $key ] ) . '"]';
/* Pattern for normal Facebook embeds */
if ( preg_match_all( '#<div id="fb-root"></div><script>[^<]+</script><div class="fb-post" [^>]+href=[\'\"]([^\'\"]+)[\'\"].+</div>(</div>)?#', $content, $matches ) ) {
$replacements = array();
$shortcode_tag = self::get_shortcode_tag();
foreach ( $matches[0] as $key => $value ) {
$replacements[ $value ] = '[' . $shortcode_tag . ' url="' . esc_url_raw( $matches[1][ $key ] ) . '"]';
}
$content = self::make_replacements_to_content( $content, $replacements );
}

/* Pattern for Facebook video embeds */
if ( preg_match_all( '#<div id="fb-root"><\/div><script>[^<]+<\/script><div class="fb-video" [^>]+href=[\'\"][^\'\"]+[\'\"]><div class="fb-xfbml-parse-ignore"><blockquote cite=[\'\"][^\'\"]+[\'\"]><a href=[\'\"]([^\'\"]+)[\'\"]+.*?<\/div><\/div>?#', $content, $matches ) ) {
$replacements = array();
$shortcode_tag = self::get_shortcode_tag();
foreach ( $matches[0] as $key => $value ) {
$replacements[ $value ] = '[' . $shortcode_tag . ' url="' . esc_url_raw( 'https://www.facebook.com' . $matches[1][ $key ] ) . '"]';
}
$content = self::make_replacements_to_content( $content, $replacements );
}
$content = self::make_replacements_to_content( $content, $replacements );
}

/* Pattern for Facebook video embeds */
if ( preg_match_all( '#<div id="fb-root"><\/div><script>[^<]+<\/script><div class="fb-video" [^>]+href=[\'\"][^\'\"]+[\'\"]><div class="fb-xfbml-parse-ignore"><blockquote cite=[\'\"][^\'\"]+[\'\"]><a href=[\'\"]([^\'\"]+)[\'\"]+.*?<\/div><\/div>?#', $content, $matches ) ) {
/* Pattern for single-line oEmbed-style links */
if ( $oembed_matches = self::parse_oembeds( $content ) ) {
$replacements = array();
$shortcode_tag = self::get_shortcode_tag();
foreach ( $matches[0] as $key => $value ) {
$replacements[ $value ] = '[' . $shortcode_tag . ' url="' . esc_url_raw( 'https://www.facebook.com' . $matches[1][ $key ] ) . '"]';
foreach ( $oembed_matches as $line => $url ) {
foreach ( self::$url_patterns as $regex ) {
if ( preg_match( $regex, $url ) ) {
$replacements[ $line ] = '[' . $shortcode_tag . ' url="' . esc_url_raw( $url ) . '"]';
}
}
}
$content = self::make_replacements_to_content( $content, $replacements );
}

return $content;
}

Expand All @@ -88,19 +113,8 @@ public static function callback( $attrs, $content = '' ) {
// See https://core.trac.wordpress.org/ticket/11311
$attrs['url'] = str_replace( '&amp;', '&', $attrs['url'] );

// Our matching URL patterns for Facebook
$facebook_regex = array(
'#https?://(www)?\.facebook\.com/[^/]+/posts/[\d]+#',
'#https?://(www)?\.facebook\.com\/video\.php\?v=[\d]+#',
'#https?:\/\/www?\.facebook\.com\/+.*?\/videos\/[\d]+\/#',
'#https?://(www)?\.facebook\.com\/permalink\.php\?story_fbid=[\d]+&id=[\d]+#',
'#https?:\/\/www?\.facebook\.com\/.*?\/photos\/([^/]+)/([\d])+/#',
'#https?:\/\/www?\.facebook\.com\/.*?\/videos\/([^/]+)/([\d])+/#',
'#https?:\/\/www?\.facebook\.com\/groups\/([\d])+\/permalink/([\d])+/?#',
);

$match = false;
foreach ( $facebook_regex as $regex ) {
foreach ( self::$url_patterns as $regex ) {
if ( preg_match( $regex, $attrs['url'] ) ) {
$match = true;
}
Expand Down
22 changes: 22 additions & 0 deletions inc/shortcodes/class-shortcode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,28 @@ protected static function parse_url( $url, $component = -1 ) {
return $ret;
}

/**
* Parse a string of content for any oembeds that can be potentially reversed.
*
* @param string $content
* @return array|false An array with the full lines matched as keys, and the URLs as values
*/
protected static function parse_oembeds( $content ) {
if ( false === stripos( $content, 'http' ) ) {
return false;
}

if ( preg_match_all( '#^(\s*)(https?://[^\s"]+)(\s*)$#im', $content, $matches, PREG_SET_ORDER ) ) {
Copy link
Contributor

@danielbachhuber danielbachhuber Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be pretty slow to run so frequently, particularly because it's matched with more regex.

$matched_lines = array();
foreach ( $matches as $matched_line ) {
$matched_lines[ $matched_line[0] ] = $matched_line[2];
}
return $matched_lines;
} else {
return false;
}
}

/**
* Parse a string of content for a given tag name.
*
Expand Down
22 changes: 22 additions & 0 deletions tests/test-facebook-shortcode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public function test_video_embed_reversal() {

<div id="fb-root"></div><script>(function(d, s, id) { var js, fjs = d.getElementsByTagName(s)[0]; if (d.getElementById(id)) return; js = d.createElement(s); js.id = id; js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.3"; fjs.parentNode.insertBefore(js, fjs);}(document, 'script', 'facebook-jssdk'));</script><div class="fb-video" data-allowfullscreen="1" data-href="/coreycf/videos/vb.100001257008891/953479961370562/?type=1"><div class="fb-xfbml-parse-ignore"><blockquote cite="/coreycf/videos/953479961370562/"><a href="/coreycf/videos/953479961370562/"></a><p>Here&#039;s the free styling he put on lol Brent John Janis Franklin Sioux Bob Nate Badmilk</p>Posted by <a href="https://www.facebook.com/coreycf">Corey James</a> on Saturday, June 27, 2015</blockquote></div></div>

https://www.facebook.com/coreycf/videos/953479961370562/
bananas after
EOT;
$transformed_content = wp_filter_post_kses( $old_content );
Expand Down Expand Up @@ -99,4 +100,25 @@ public function test_photo_embed_reversal() {

}

public function test_oembed_reversals() {

$old_content = <<<EOT

apples before

https://www.facebook.com/RichardBranson/photos/a.10151193550160872.451061.31325960871/10151193550380872/?type=1

https://www.facebook.com/coreycf/videos/953479961370562/

bananas after
EOT;

$transformed_content = wp_filter_post_kses( $old_content );
$transformed_content = str_replace( '\"', '"', $transformed_content ); // Kses slashes the data
$this->assertContains( '[facebook url="https://www.facebook.com/RichardBranson/photos/a.10151193550160872.451061.31325960871/10151193550380872/?type=1"]', $transformed_content );
$this->assertContains( '[facebook url="https://www.facebook.com/coreycf/videos/953479961370562/"]', $transformed_content );
$this->assertContains( 'apples before', $transformed_content );
$this->assertContains( 'bananas after', $transformed_content );
}

}