Require select elements to have a value set #329
Conversation
On registering UI for shortcode, checks that any attributes of type "select" have a value set. If not, sets their value to the key of the first option, as this is the behavior that will be expected by the user who sees that the first element in the select list appears to be selected on the form.
|
I'm really not sure where this logic should live. I tried it in a couple of different places: in the Putting this logic in the view would make the most sense to me, as that's what it really affects, but the logic involved there was ugly, since the attribute inherits defaults which could be falsy. An initialize function in the attribute model could work, but this was this simplest approach I could think of. As a matter of fact, I kind of think some more solid validation of shortcode attributes probably should be done in PHP before sending the shortcode attrs to javascript. I'd like to hear thoughts on this if anyone has ideas. |
|
@sanchothefat Any opinions? |
|
Hmm... i'm not sure this is the right place for this. Although it is nice and simple. I think this should probably go in the view, or possibly the attribute model. |
This was also made moot by #336, which now triggers the view's |
On registering UI for a shortcode, checks that any attributes of type "select" have a value set.
If not, sets their value to the key of the first option, as this is the behavior that will be expected by the user who sees that the first element in the select list appears to be selected on the form.
See #323.