Use "regular-text" class for inputs in WordPress admin #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress has some distinctive admin styles for form elements. Applying the base classes which WP uses to mark up form elements will make the shortcode UI form look less incongruous with the rest of the admin area.
danielbachhuber
pushed a commit
that referenced
this pull request
May 20, 2015
Use "regular-text" class for inputs in WordPress admin
Contributor
|
🌵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress has some distinctive admin styles for form elements. Applying the base classes which WP uses to mark up form elements will make the shortcode UI form look less incongruous with the rest of the admin area. It's also easier to enter text with a wider input (
regular-textis 25em wide; browser defaults for input width vary, but can be as low as 150px on Firefox)Text boxes, before:
After: