Make sure shortcode prop is set #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @mattheu ! |
Contributor
danielbachhuber
pushed a commit
that referenced
this pull request
Jun 3, 2015
Make sure shortcode prop is set
Contributor
|
Ah, thanks for the fix @mattheu. I didn't see that issue... guess I didn't test with a shortcode containing inner content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced here: c575c65
Problem - the
shortcodeproperty on the view was not getting set correctly. Caused the following error when trying to edit a shortcode.Uncaught TypeError: Cannot read property 'attributes' of undefinedWhy? In recent versions of Backbone - you cannot pass arbitrary properties to a view. This wasn't an issue before - because we just weren't using it.
This problem only affects the
inner_contentfield - because for all other fields, we set the shortcode property after instantiating - which works OK.The fix - set properties in the same way for
inner_contentfield view that they are for all other fields to ensure it is actually set.