Only call get_current_screen() when the function exists
#355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_current_screen()` only exists in admin context. While Shortcode UI isn't full supported on the frontend, not fataling is the least we can do
Contributor
Author
|
@mattheu How do you feel about this? |
Contributor
|
Agreed that there isn't really a better way to handle this. |
danielbachhuber
pushed a commit
that referenced
this pull request
Jun 8, 2015
Only call `get_current_screen()` when the function exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_current_screen()only exists in admin context. While Shortcode UI isn't full supported on the frontend, not fataling is the least we can doFixes #337