Remove unused method for fetching preview of single shortcode #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the unused "fetch()" method from Shortcode View constructor (it was confusingly making a request to the 'do_shortcode' ajax endpoint, which was removed a long time ago). Also removes the nonce which is set with each separate query in the bulk_do_shortcode request - since #743, a single nonce is being sent as a top-level field on the request and is being checked by the 'bulk_do_shortcode' endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #743 (comment)
Removes the unused "fetch()" method from Shortcode View constructor (it was confusingly making a request to the 'do_shortcode' ajax endpoint, which was removed a long time ago). Also removes the nonce which is set with each separate query in the bulk_do_shortcode request - since #743, a single nonce is being sent as a top-level field on the request and is being checked by the 'bulk_do_shortcode' endpoint.
This is causing some test failures, because we have specs still testing the shortcode constructor.fetch() function. There's no reason to test this function since its no longer used, but I didn't want to remove the tests without replacing them with tests that cover the .delayedFetch() function, and that will take a bit of thought.