Skip to content

Fix to improve the use of Text Domain for translations and updated version of bones #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix to improve the use of Text Domain for translations and updated version of bones #32

wants to merge 1 commit into from
+966 −672

Conversation

bredecl
Copy link

@bredecl bredecl commented Mar 25, 2025

  • updated bones to use current
  • add support for get textdomain from config/options.php
  • add transversal support for WPBONES_TEXTDOMAIN

@bredecl
- updated bones to use current
6eeb521 
- add support for get textdomain from config/options.php
- add transversal support for WPBONES_TEXTDOMAIN
bredecl added a commit to bredecl/WPBones_2 that referenced this pull request Mar 25, 2025
@bredecl
Self Generated Menus from CTT and extended use of WPBONES_TEXTDOMAIN
4282bad 
WIP: Add support for WPBONES_TEXTDOMAIN
- Added a Menu Relations to self generated menus from CTT
- Added support to make use of WPBONES_TEXTDOMAIN on Admin Menu Provider

Important, this could lead to a break on your code, you *need* to add at least
```
defined("WPBONES_TEXTDOMAIN","your_text_domain");
```
in `config.php`

or update your code based on wpbones/WPKirk#32
@gfazioli
Copy link
Collaborator

@bredecl thank you for your fixes 🙏
jfyi, as mentioned here #22, we're going to deprecate/dismiss the complete WPKirk demo. Instead, we will use a single and clearer/easier demo/boilerplate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bredecl @gfazioli