[util] Remove patch that results in building with NDEBUG causing ODR issues#8539
Merged
PeterJohnson merged 1 commit intowpilibsuite:2027from Jan 3, 2026
Merged
Conversation
PeterJohnson
approved these changes
Jan 3, 2026
PeterJohnson
approved these changes
Jan 3, 2026
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered by @virtuald when trying to build robotpy.
Semiwrap / meson / robotpy define
NDEBUGwhen building their software in all modes, whileallwplibonly does it when building debug. This causes the size ofDenseMapto differ between the shared libraries built here, and the extension modules built inmostrobotpy, causing segfaults when you try to execute code that usesDenseMap. This is not a problem with the robotpy code inallwpilib, because bazel uses the exact same compiler flags when building the shared libraries and pybind11 extensions. #TeamBuildEverythingFromSourceSome offline chats: