Added a few more components, including some that have non-port arguments #368
Conversation
Fixed isEnum. Removed getComponentPortNameAndType. Changes to python_tools/json_util.py: Generate JSON componentArgs for component constructors, instead of componentPortName and componentPortType. Added _createArgData. Added _processComponent.
…_json_types.ts Added preupgrade_009_to_0010 to change Component.ports to Component.args.
…g into component input sockets.
…all components have a port argument and no other arguments. Fixed the code that generates the robot when it creates a mechanism, passing one tuple of args for each component in the mechanism. Fixed the code that generates a mechanism's __init__ and define_hardware methods. The __init__ and define_hardware methods take one parameter (which is is a tuple) for each component in the mechanism. The define_hardware method uses the * operator to unpack the elements of the tuple and pass each element as a separate positional argument to the component constructor.
Upgrade old projects so that Components have args instead of ports.
…face into pr_more_components
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
How did you test all of these changes? The code looks reasonable to me, and if you feel like it is tested well I am good with your merging it.
I tested the blocks editor side of things and made sure it generated appropriate python code for normal components (that take a port, including both simple and compound ports), onboard imu (which takes a mount enum, but no port), and analog potentiometer (which takes a port and two other numeric arguments). I tried to run the python code, but the analog potentiometer class in wpilib doesn't seem to work with the REV potentiometer that I have. But I was able to run blocks-generated python code that uses DigitalSensor, ExpansionHubMotor, and ExpansionHubServo. |
2 participants
Generate JSON componentArgs for component constructors, instead of componentPortName and componentPortType. Fixed python code that recognizes enums.
Moved PortType and related functions from module_content.ts to python_json_types.ts
Increment the current version to 0.0.10. Upgrade old projects so that Components have args instead of ports.
Changed blocks and the python generator where it used to assume that all components have a port argument and no other arguments.
Fixed the code that generates the robot when it creates a mechanism, passing one tuple of args for each component in the mechanism.
Fixed the code that generates a mechanism's init and define_hardware methods. The init and define_hardware methods take one parameter (which is is a tuple) for each component in the mechanism. The define_hardware method uses the * operator to unpack the elements of the tuple and pass each element as a separate positional argument to the component constructor.
Fixes #366
Fixes #367