Pr upload download #373
Open
Pr upload download #373
+150
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizlooney
requested changes
Jan 2, 2026
| items={menuItems} | ||
| onClick={handleClick} | ||
| /> | ||
| {showUploadAndDownload ? ( |
| const [noProjects, setNoProjects] = React.useState<boolean>(false); | ||
| const [aboutDialogVisible, setAboutDialogVisible] = React.useState<boolean>(false); | ||
| const [themeModalOpen, setThemeModalOpen] = React.useState<boolean>(false); | ||
| const [showUploadAndDownload, _setShowUploadAndDownload] = React.useState(false); |
| } | ||
| }; | ||
|
|
||
| // TODO: Add UI for the download action. |
Collaborator
There was a problem hiding this comment.
Remove the TODO comment.
|
|
||
| // TODO: Add UI for the upload action. | ||
| /** Handles the upload action to upload a previously downloaded project. */ | ||
| const handleUploadClick = (): void => { |
Collaborator
There was a problem hiding this comment.
We already have handleUpload (line 520). Can you update the existing handleUpload (if necessary) instead of adding this new function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
This uses the already existing download/upload but adds a UI around it including name conflict resolution on upload.
Note that the automatic changing to the new project exposes a bug (fixed in #372) but that is not a bug in this PR.
After downloading and uploading the same, I went through the pr checklist and it all passes on my machine.
(I substituted the upload for the making a new project)