Skip to content

Fix the source of the dt=0 error when using adaptive time step #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-v4.6.1
Choose a base branch
from
Open

Fix the source of the dt=0 error when using adaptive time step #2103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 11 additions & 22 deletions dyn_em/adapt_timestep_em.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,19 +290,17 @@ RECURSIVE SUBROUTINE adapt_timestep(grid, config_flags)

if ( ( tmpTimeInterval .LT. dtInterval * 2 ) .and. &
( tmpTimeInterval .GT. dtInterval ) ) then
dtInterval = tmpTimeInterval / 2

num = INT((time_to_bc * precision)/2 + 0.5)
den = precision
CALL WRFU_TimeIntervalSet(dtInterval, Sn=num, Sd=den)

use_last2 = .TRUE.
stepping_to_bc = .true.
grid%stepping_to_time = .TRUE.

elseif (tmpTimeInterval .LE. dtInterval) then

bc_time = NINT ( (curr_secs + time_to_bc) / ( grid%interval_seconds ) ) &
* ( grid%interval_seconds )
CALL WRFU_TimeIntervalSet(tmpTimeInterval, S=bc_time)
dtInterval = tmpTimeInterval - &
(domain_get_current_time(grid) - domain_get_start_time(grid))
dtInterval = tmpTimeInterval

use_last2 = .TRUE.
stepping_to_bc = .true.
Expand Down Expand Up @@ -333,25 +331,16 @@ RECURSIVE SUBROUTINE adapt_timestep(grid, config_flags)

if ( ( tmpTimeInterval .LT. dtInterval * 2 ) .and. &
( tmpTimeInterval .GT. dtInterval ) ) then
dtInterval = tmpTimeInterval / 2

num = INT((time_to_output * precision)/2 + 0.5)
den = precision
call WRFU_TimeIntervalSet(dtInterval, Sn=num, Sd=den)

use_last2 = .TRUE.
grid%stepping_to_time = .TRUE.

elseif (tmpTimeInterval .LE. dtInterval) then
!
! We will do some tricks here to assure that we fall exactly on an
! output time. Without the tricks, round-off error causes problems!
!

!
! Calculate output time. We round to nearest history time to assure
! we don't have any rounding error.
!
output_time = NINT ( (curr_secs + time_to_output) / &
(history_interval_sec) ) * (history_interval_sec)
CALL WRFU_TimeIntervalSet(tmpTimeInterval, S=output_time)
dtInterval = tmpTimeInterval - &
(domain_get_current_time(grid) - domain_get_start_time(grid))
dtInterval = tmpTimeInterval

use_last2 = .TRUE.
grid%stepping_to_time = .TRUE.
Expand Down