-
Notifications
You must be signed in to change notification settings - Fork 800
instruct GitHub to create empty, instead of incomplete, release tarballs (via .gitattributes) #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…lls (via .gitattributes)
islas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good semi-solution to GitHub's lack of archive control on releases! I think ideally we would want to just disable it, but this should make the error obvious to those that download the wrong archive. We should still keep the bold warning in addition to this.
|
FWIW, here's a link to github workflow step we use in GDL to upload submodule-aware tarballs to GitHub release pages automatically (when creating a release via GitHub website): |
|
The results from regression tests: |
|
@weiwangncar What do you think about this? It could be useful to avoid users trying to download the wrong zip/tar files. |
|
@islas It seems useful and can avoid confusion. But we may want to do this in 4.8? |
|
@weiwangncar Yes, I think for v4.8.0 this would be good. I've tested this locally in other github repos to make sure the auto-generated archives are empty. |
PURPOSE: instruct GitHub to create empty, instead of incomplete, release tarballs (via .gitattributes)
TYPE: enhancement
KEYWORDS: release, gitmodules
SOURCE: @slayoo
DESCRIPTION OF CHANGES:

Problem:
Solution:
Make the auto-generated files empty (seems that disabling auto-generation entirely is not supported)
ISSUE: none ?
LIST OF MODIFIED FILES:
.gitattributesaddedTESTS CONDUCTED:
Tested to work in another project: https://github.com/gnudatalanguage/gdl/blob/master/.gitattributes
RELEASE NOTE: minor change not affecting the proper release files, hence not needed to be mentioned in release notes