[TM-1772] Implement file / media GET in v3 #122
Conversation
pachonjcl
changed the title
roguenet
changed the base branch from
staging
to
release/captivating-chrysoberyl
apps/entity-service/src/entities/processors/association-processor.ts
Outdated
Show resolved
Hide resolved
apps/entity-service/src/entities/processors/association-processor.ts
Outdated
Show resolved
Hide resolved
libs/common/src/lib/decorators/transform-boolean-string.decorator.ts
Outdated
Show resolved
Hide resolved
LimberHope
changed the base branch from
release/captivating-chrysoberyl
to
staging
| entityType: additional.entityType, | ||
| entityUuid: additional.entityUuid, | ||
| url: additional.url, | ||
| thumbUrl: additional.thumbUrl, |
There was a problem hiding this comment.
These should be covered by ...additional above and do not need to be specified separately.
There was a problem hiding this comment.
unfortunately it is because of typescript, I just updated.
There was a problem hiding this comment.
I think this is not the right solution. If you look at the particulars of the error that TS gives you, it's legitimately flagging that url is optional in the additional props, but required in the DTO. That's a real error, and it should be addressed appropriately with an update to the DTO, or a default value.
| ...additional | ||
| ...additional, | ||
| entityType: additional.entityType, | ||
| entityUuid: additional.entityUuid |
There was a problem hiding this comment.
These are covered by ...additional above and do not need to be specified separately.
There was a problem hiding this comment.
unfortunately it is because of typescript, I just updated.
Task Link