Skip to content

Merges https://github.com/RWOverdijk/AssetManager/pull/202 into v2 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

wshafer
Copy link
Owner

@wshafer wshafer commented Jul 28, 2017

Tested on local project and everything seems to still work. Merging

@wshafer wshafer closed this Jul 28, 2017
@wshafer wshafer reopened this Jul 28, 2017
@wshafer wshafer merged commit 39d4095 into master Jul 28, 2017
@RWOverdijk
Copy link
Collaborator

What happened here :p

@wshafer
Copy link
Owner Author

wshafer commented Jul 31, 2017

Just merged RWOverdijk/AssetManager#202 into this v2 line per the issue and pr. I wasn't sure about it at first, but now that's it's in, it feels more "correct." Plus the we don't need to use incorrect mime types anymore. Win/Win if you ask me.

@wshafer
Copy link
Owner Author

wshafer commented Jul 31, 2017

In addition... it makes a lot more sense after you look at this PR... #22 which switches the filters to the source extension instead of the incorrect extensions that were being provided by the mimetype resolver. I think #21 and #22 are good changes IMO.

@wshafer wshafer deleted the mime-type-switch branch September 21, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants