Skip to content

feat: add imagePullSecret reference configuration option #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schaer-bgs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add imagePullSecret reference configuration option #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion all-in-one/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ A Helm chart for the deployment of WSO2 API Manager all-in-one distribution.
| wso2.deployment.highAvailability | bool | `false` | |
| wso2.deployment.image.digest | string | `""` | Docker image digest |
| wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries |
| wso2.deployment.image.registry | string | `""` | Registry containing the image |
| wso2.deployment.image.repository | string | `""` | Repository name consisting the image |
| wso2.deployment.image.tag | string | `""` | Docker image tag |
Expand Down
1 change: 1 addition & 0 deletions all-in-one/default_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
name: ""
username: ""
password: ""
# -- Registry containing the image
Expand Down
4 changes: 4 additions & 0 deletions all-in-one/templates/am/instance-1/wso2am-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "am-all-in-one.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am
Expand Down
4 changes: 4 additions & 0 deletions all-in-one/templates/am/instance-2/wso2am-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "am-all-in-one.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am
Expand Down
2 changes: 1 addition & 1 deletion all-in-one/templates/secrets/wso2am-secret-docker-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }}
# -------------------------------------------------------------------------------------
#
# Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved.
Expand Down
1 change: 1 addition & 0 deletions all-in-one/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
name: ""
username: ""
password: ""
# -- Registry containing the image
Expand Down
2 changes: 1 addition & 1 deletion distributed/control-plane/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ A Helm chart for the deployment of WSO2 API Management API Control Plane profile
| wso2.deployment.highAvailability | bool | `true` | Enable high availability for traffic manager. If this is enabled, two traffic manager instances will be deployed. This is not relavant to HA in Kubernetes. Multiple replicas of the same instance will not count as HA for TM. |
| wso2.deployment.image.digest | string | `""` | Docker image digest |
| wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries |
| wso2.deployment.image.registry | string | `""` | Container registry hostname |
| wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image |
| wso2.deployment.image.tag | string | `""` | Docker image tag |
Expand Down
4 changes: 4 additions & 0 deletions distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-cp.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-control-plane
Expand Down
4 changes: 4 additions & 0 deletions distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-cp.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-control-plane
Expand Down
2 changes: 1 addition & 1 deletion distributed/control-plane/templates/secrets/wso2am-secret-docker-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }}
# -------------------------------------------------------------------------------------
#
# Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved.
Expand Down
1 change: 1 addition & 0 deletions distributed/control-plane/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
name: ""
username: ""
password: ""
# -- Container registry hostname
Expand Down
2 changes: 1 addition & 1 deletion distributed/gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ A Helm chart for the deployment of WSO2 API Management Universal Gateway profile
| wso2.deployment.envs | object | `{}` | Environment variables for the deployment Example: envs: MY_CUSTOM_VAR: "my-value" ANOTHER_VAR: "another-value" |
| wso2.deployment.image.digest | string | `""` | Docker image digest |
| wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries |
| wso2.deployment.image.registry | string | `""` | Container registry hostname |
| wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image |
| wso2.deployment.image.tag | string | `""` | Docker image tag |
Expand Down
4 changes: 4 additions & 0 deletions distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-gw.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-gateway
Expand Down
2 changes: 1 addition & 1 deletion distributed/gateway/templates/secrets/wso2am-secret-docker-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }}
# -------------------------------------------------------------------------------------
#
# Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved.
Expand Down
1 change: 1 addition & 0 deletions distributed/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
name: ""
username: ""
password: ""
# -- Container registry hostname
Expand Down
2 changes: 1 addition & 1 deletion distributed/key-manager/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ A Helm chart for the deployment of WSO2 API Manager all-in-one distribution.
| wso2.deployment.highAvailability | bool | `false` | Enable high availability for key manager. If this is enabled, two key manager replicas will be deployed. |
| wso2.deployment.image.digest | string | `""` | Docker image digest |
| wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries |
| wso2.deployment.image.registry | string | `""` | Container registry hostname |
| wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image |
| wso2.deployment.image.tag | string | `""` | Docker image tag |
Expand Down
4 changes: 4 additions & 0 deletions distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-km.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-km
Expand Down
2 changes: 1 addition & 1 deletion distributed/key-manager/templates/secrets/wso2am-secret-docker-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }}
# -------------------------------------------------------------------------------------
#
# Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved.
Expand Down
1 change: 1 addition & 0 deletions distributed/key-manager/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
namme: ""
username: ""
password: ""
# -- Container registry hostname
Expand Down
2 changes: 1 addition & 1 deletion distributed/traffic-manager/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ A Helm chart for the deployment of WSO2 API Management Traffic Manager profile
| wso2.deployment.highAvailability | bool | `true` | Enable high availability for traffic manager. If this is enabled, two traffic manager instances will be deployed. This is not relavant to HA in Kubernetes. Multiple replicas of the same instance will not count as HA for TM. |
| wso2.deployment.image.digest | string | `""` | Docker image digest |
| wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries |
| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,name:"","password":"","username":""}` | Container registry credentials. Specify image pull secrets or a reference to secret for private registries |
| wso2.deployment.image.registry | string | `""` | Container registry hostname |
| wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image |
| wso2.deployment.image.tag | string | `""` | Docker image tag |
Expand Down
2 changes: 1 addition & 1 deletion distributed/traffic-manager/templates/secrets/wso2am-secret-docker-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }}
# -------------------------------------------------------------------------------------
#
# Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved.
Expand Down
4 changes: 4 additions & 0 deletions distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-tm.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-traffic-manager
Expand Down
4 changes: 4 additions & 0 deletions distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ spec:
{{- end }}
{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }}
imagePullSecrets:
{{- if .Values.wso2.deployment.image.imagePullSecrets.name }}
- name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }}
{{- else }}
- name: {{ template "apim-helm-tm.fullname" . }}-docker-registry-auth
{{- end }}
{{- end }}
containers:
- name: wso2am-traffic-manager
Expand Down
1 change: 1 addition & 0 deletions distributed/traffic-manager/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ wso2:
# Specify image pull secrets for private registries
imagePullSecrets:
enabled: false
name: ""
username: ""
password: ""
# -- Container registry hostname
Expand Down