make abbreviation optional #4
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandro Pischinger <mail@sandropischinger.de>
pklaschka
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Hey there – sorry this took so long! I completely missed the PR (and watching the repo to get notified about PRs, for that matter) 🙈.
This looks good to me – I'll merge it for the next release (which I'm currently working on to fix stuff breaking with Typst v0.13). Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the
abbreviationfield to be set tononethus not being displayed.Details
If the abbreviation is
none, it will not be shown. Butabbreviationwill still be set to null in the metadata fields of the document.CLA