This repository was archived by the owner on Apr 25, 2018. It is now read-only.
removes cors module#8
Open
yannickoo wants to merge 1 commit intowunderio:masterfrom
yannickoo:remove-cors-module
Open
removes cors module#8yannickoo wants to merge 1 commit intowunderio:masterfrom yannickoo:remove-cors-module
yannickoo wants to merge 1 commit intowunderio:masterfrom
yannickoo:remove-cors-module
Conversation
Contributor
Author
|
Can we remove corresponding patches then from |
Contributor
|
There are a couple of patches to use JSONP, but we need to make sure that all the endpoints use CORS in the clients (the initial version used JSONP for the employees endpoint) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pcambra mentioned that we should configure CORS on the server-side so we need to remove that from the
contrib.makefile.