refactor: move to module-runner #1946
Open
+26
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this could be breaking in theory, but... - If you're using the default setup, you're already good. - If you've customized your Vite version, you probably thought it was a peer.
Related: wxt-dev#1214. Related: wxt-dev#1044.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Drop
vite-nodein favor of Vite-nativerunnerImport, which is based onModuleRunner.Manual Testing
Good question... not entirely sure what fails the treeshake in the first place, but all the tests pass so I assume it loads the entrypoints at least. 🤷🏻♂️
Related Issue
Stacked on #1945.
Supersedes/closes #1884.