[NUOPEN-296] Fix daily booking issue

[diebas]

Notes

Fix daily booking validation to properly enforce minimum and maximum reservation days. Previously, when creating a reservation for a daily booking instrument, the system only checked max_reserve_mins and min_reserve_mins (which are nil for daily bookings), allowing users to create reservations that exceeded the configured max_reserve_days limit.

NUOPEN-296 | Issue related with Daily booking

Additional Context

Root Cause

The validation methods satisfies_minimum_length? and satisfies_maximum_length? in app/support/reservations/validations.rb were only checking minute-based fields:

# Before fix - always returned true for daily bookings because max_reserve_mins is nil
def satisfies_maximum_length?
  return true if product.max_reserve_mins.to_i == 0  # nil.to_i == 0, so always true
  # ... rest of validation never executed for daily bookings
end

[LeticiaErrandonea]

LGTM!

[LeticiaErrandonea]

Does this make sense?

Suggested change

	true if product.min_reserve_mins.nil? || product.min_reserve_mins == 0 || diff / 60 >= product.min_reserve_mins
	product.min_reserve_mins.nil? || product.min_reserve_mins == 0 || diff / 60 >= product.min_reserve_mins