refactor: deduplicate checkIfBazaarNeeded across HTTP packages#1925
Open
natsukingly wants to merge 1 commit intox402-foundation:mainfrom
Open
refactor: deduplicate checkIfBazaarNeeded across HTTP packages#1925natsukingly wants to merge 1 commit intox402-foundation:mainfrom
natsukingly wants to merge 1 commit intox402-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkIfBazaarNeededwas duplicated identically across 4 HTTP middleware packages (Express, Hono, Fastify, Next.js). This PR extracts it into@x402/coreand replaces the local copies with a shared import.Changes
checkIfBazaarNeededtox402HTTPResourceServer.tsas an exported function@x402/core/server@x402/http-express,@x402/http-hono,@x402/http-fastify,@x402/http-nextMotivation
Reduces maintenance burden — any future changes to bazaar detection logic only need to happen in one place.
Test plan
pnpm run build)pnpm run test)