fix: respect Retry-After header on 429 responses in facilitator client#1929
Open
natsukingly wants to merge 1 commit intox402-foundation:mainfrom
Open
fix: respect Retry-After header on 429 responses in facilitator client#1929natsukingly wants to merge 1 commit intox402-foundation:mainfrom
natsukingly wants to merge 1 commit intox402-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The HTTP facilitator client ignores the
Retry-Afterheader on 429 (Too Many Requests) responses, using fixed exponential backoff instead. This can cause unnecessary delays or premature retries.Changes
Retry-Afterheader value (integer seconds) on 429 responsesRetry-Afteris absent or unparseableBehavior
Test plan