-
Notifications
You must be signed in to change notification settings - Fork 16
Adds land-sea mask generation #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasonb5
wants to merge
23
commits into
main
Choose a base branch
from
feature/576-landsea-mask
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
66dc9ab
Refactors grid generation and updates generating bounds
jasonb5 b7de60e
Fixes dtype in gaussian grid creation
jasonb5 895b617
Initial land-sea mask implementation
jasonb5 9312414
Fixes exception that occurs when landsea mask resource is missing
jasonb5 a657628
Fixes copying mask as it's modified in place by _improve_mask
jasonb5 2e2a3c7
Fixes returning DataArray from _pcmdi_land_sea_mask
jasonb5 8c4025b
Renames accessor and masking methods
jasonb5 ee87e77
Fixes broken test expecting dataarray
jasonb5 38741d0
Adds option to output mask in dataset
jasonb5 63b9843
Adds dispatcher options and updates documentation
jasonb5 b833cbd
Fixes missing import for MaskAccessor
jasonb5 daffcba
Changes function names and updates docstrings
jasonb5 20c1a58
Adds documentation section for module-level methods
jasonb5 bbc39ad
Adds ability to define the source mask to use in the PCMDI land-sea m…
jasonb5 c0b4881
Fixes documentation function reference
jasonb5 801be86
Refactor land-sea mask handling and documentation
tomvothecoder a08548e
Moves land/sea mask from geomask to spatial accessor, exposes generat…
jasonb5 397ee15
Fixes generating mask for a grid
jasonb5 def3bff
Adds land/sea mask example
jasonb5 0034439
Updates landsea mask notebook
jasonb5 512c471
Re-run notebook to remove env error
tomvothecoder b13773d
Address Copilot review comments
tomvothecoder f1a9d5b
Renames criteria to threshold and corrects documentation via copilot …
jasonb5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.