-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maidr.show): support interactive maidr plots within Jupyter Notebooks, VS Code, Google Colab, and Quarto #64
Merged
+9,510
−2
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fccdbc6
fix: issue with interactivity in ipython notebooks
dakshpokar 0136196
fix: lint issues
dakshpokar 71c4279
fix: lint fixes
dakshpokar de8c1c6
fix: resizing issue of iframe
dakshpokar 243ff5c
chore: cleaned up code
dakshpokar 7cc65b9
fix: cleaned up code and fixed the feedbacks by saairam
dakshpokar f97aa43
chore: removed unnecessary imports
dakshpokar 136e30f
fix: follow up feedbacks resolved
dakshpokar b5898ee
chore: removed unnecessary imports
dakshpokar f39d1d1
chore: updated comment
dakshpokar a27fa5b
fix: added example jupyter notebooks for each plot type
dakshpokar 4441c0c
docs(quarto): add Quarto example
jooyoungseo b3f5631
chore: comment out plt.show
jooyoungseo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
class Environment: | ||
@staticmethod | ||
def is_interactive_shell() -> bool: | ||
"""Return True if the environment is an interactive shell.""" | ||
try: | ||
from IPython.core.interactiveshell import InteractiveShell | ||
|
||
return ( | ||
InteractiveShell.initialized() | ||
and InteractiveShell.instance() is not None | ||
) | ||
except ImportError: | ||
return False |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Daksh,
When I worked on the py-shiny renderer, I faced a UI/UX issue when displaying the generated MAIDR plot on the shiny component. The major problem with the behaviour I observed on Shiny was that the overflow properties were triggered if pre-defined styles were used.
Can you share your findings on how Python notebooks renders the cells? After looking at the documentation, I can see that style customizations are allowed for Python notebooks. Does overflow get applied to the plot if pre-defined styles are employed?
Regards,
Krishna Anandan Ganesan.