Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix wk web view navigation delegate on page callbacks #413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Abhirasmanu-Trimble
Copy link

Xamarin.Auth Pull Request

Fixes 1.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Call WebAuthenticator.OnPageLoading from DidStartProvisionalNavigation
  • Call WebAuthenticator.OnPageLoaded from DidFinishNavigation

@Abhirasmanu-Trimble
Copy link
Author

Fix for : #411

@JakubHolovsky
Copy link
Contributor

any chances of merging this and releasing it on nuget?

@friendly-tech
Copy link

@Abhirasmanu-Trimble
Any chance of fixing the issues and trying to get this merged ?

@Abhirasmanu-Trimble
Copy link
Author

@Abhirasmanu-Trimble
Any chance of fixing the issues and trying to get this merged ?

I do not have write access to this repository.

@friendly-tech
Copy link

Approved now - please can someone merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants