This repository has been archived by the owner on May 1, 2024. It is now read-only.
OAuth1 - add optional parameter to put oauth parameters in header instead of query string #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…merge this to Xamarin.Auth.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xamarin.Auth Pull Request
Fixes # .
Checklist
Changes proposed in this pull request:
This is a patch to v1.7.0 and was based on the 1.7.0 tag.
I use the Xamarin.Auth library against www.trademe.co.nz. They still use OAuth1, and recently improved security by forcing the oauth_ parameters to be provided in the header instead of the query string.
This change provides an optional parameter (default to false, or existing behaviour) which a dev can use to ensure oauth_ parameters are placed in the header instead of the query string.