This repository has been archived by the owner on May 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 72
Added location support to Twitter and Facebook #25
Open
aphex3k
wants to merge
14
commits into
xamarin:master
Choose a base branch
from
aphex3k:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned ermau
Sep 3, 2013
src/Xamarin.Social/OAuth1Service.cs
Outdated
// | ||
// This is a reliable URL to redirect to | ||
// | ||
CallbackUrl = new Uri ("http://www.facebook.com/connect/login_success.html"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't related to adding location support, please submit separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, no problem
…amarin.Social.Services.FacebookService.<ShareItemWithLocationAsync>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to use Xamarin.Social for sharing pictures from a camera component in an app. I noticed that it yet lacks location support. I added my humble idea of location support and would like some input.
The way it currently works is, that the app determines it's location and assigns lat and long values to the Location property of the item. If the values are set, we pass them verbatim to the Twitter Api. For Facebook we have to find a place_id first. An additional request is necessary for this. I imagine the API for App.net being similar to Twitter in this regard.
michael