This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
KotlinXCoroutines-1.4.3.1-targets-files-fixes #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
reviewed
May 17, 2021
Comment on lines
46
to
47
| <None Include="..\..\externals\kotlinx-coroutines-android-$(ArtifactVersion).jar" Pack="True" PackagePath="jar\kotlinx-coroutines-android-$(ArtifactVersion).jar" Visible="false" /> | ||
| <EmbeddedJar Include="..\..\externals\kotlinx-coroutines-android-$(ArtifactVersion).jar" Link="Jars\kotlinx-coroutines-android-$(ArtifactVersion).jar" /> |
There was a problem hiding this comment.
What do these lines do?
It seems like they're going to add the .jar to the .nupkg twice: once embedded in the .dll and once as a loose .jar file.
There was a problem hiding this comment.
It looks to be added twice, but this is probably because the accompanying .targets file is not added to the nuget - and then this was added back.
The .targets file should be added to build and buildTransitive
I am a dummy, the targets file is added in the lines above. This is embedding unnecessarily.
There was a problem hiding this comment.
It seems like we shouldn't be adding .targets files or adding loose .jar files at all, but I guess we do it with all of our packages so I guess it's ok.
jpobst
approved these changes
May 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring + fixes:
PackageVersion and ArtifactVersion
suffixes in targets files added
details: KotlinX.Coroutines buildTransitive - jar files w/o version suffix #1172
javasources download (since version 1.4.3 there are no javadocs)
JavaSourceJaradded