VLAN filtering design document#7102
Conversation
|
|
||
| * VIF.set_trunks | ||
| * self (ref VIF): reference to a valid VIF; | ||
| * tags (set int): The 802.1Q VLANs which will be associated with the VIF. |
There was a problem hiding this comment.
Generally good. I agree with adding it to VIF object.
Two tiny points:
- How about replace the param name tag/tags to vlan/vlans. I think tag is used in the access port, while vlan is more explicit.
- Could you mention the impact of the new added filed on different cases like VM start, live-migrate, XAPI restart and update from the older version etc.
There was a problem hiding this comment.
-
No problem for vlan/vlans renaming.
-
Regarding impact's mention, I will try to do it but I am unsure I will be able to be exhaustive on all events that could occurs on VIF. In
behavior changeit tried to explain that the purpose is to synchronize the new trunks attribute on VIF totrunksattribute onPorttable in OpenvSwitch. Rereading the paragraph, I added a mention that it isn't only "when a VIF is created" but during the whole lifecycle of the port.
I have mentioned:
- Update from older version
- VM start
- VM migration
- VIF attribute changes
There was a problem hiding this comment.
How about replace the param name tag/tags to vlan/vlans. I think tag is used in the access port, while vlan is more explicit.
The usual convention for a parameter name like this is value, which is used for all generated setters.
There was a problem hiding this comment.
I changed the parameters name to follow the usual convention.
thanks.
changlei-li
left a comment
changlei-li
left a comment
There was a problem hiding this comment.
nit: some typos below
|
I think this looks reasonable. It is helpful to see the design considerations explained in this document and I agree with the choice. |
semarie
force-pushed
the
srt-wip/design/vlan-filtering
branch
from
574a0c3 to
38893c7
Compare
With input from changlei-li, minglumlu, and robhoes Signed-off-by: Sebastien Marie <semarie@kapouay.eu.org>
semarie
force-pushed
the
srt-wip/design/vlan-filtering
branch
from
38893c7 to
76a8128
Compare
|
I squashed the commits and changed the Please note that I didn't found documentation about the design document lifecycle. Any pointer would be welcomed. |
5 participants
I would like to discuss the following design document before proposing the related implementation.