Update ocaml-qcow to 0.14.0#755
Merged
last-genius merged 3 commits intoApr 20, 2026
Merged
Conversation
psafont
approved these changes
Feb 18, 2026
Member
psafont
left a comment
There was a problem hiding this comment.
The failure is expected because there's a breaking change in the API
lindig
approved these changes
Feb 18, 2026
last-genius
added a commit
to xcp-ng-rpms/xs-opam-repo
that referenced
this pull request
Mar 6, 2026
Tarball generated from last-genius/xs-opam@d1a83e3, pending upstream merge in xapi-project/xs-opam#755 Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
d1a83e3 to
b3c6d07
Compare
psafont
reviewed
Apr 9, 2026
| ["qemu-utils"] {os-family = "ubuntu"} | ||
| ["qemu-img"] {os-family = "fedora"} | ||
| ["qemu-img"] {os-distribution = "rhel"} | ||
| ["epel-release" "qemu-img"] {os-distribution = "centos"} |
Member
There was a problem hiding this comment.
note: this doesn't seem to enforce any distrivution package to when building xs-opam-repo, because it's not `os-family = "centos"
This seems to be what both xcp-ng and xenserver need now to avoid introducing conflicts regarding package names, and only enforce the dependency on the spec level when testing vhd-tool, if it's tested.
b3c6d07 to
14a4f93
Compare
Collaborator
|
Contributor
Author
Yes, the corresponding xapi PR drops the usage of this interface entirely: xapi-project/xen-api#6895 (review) |
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
14a4f93 to
5b7ee35
Compare
Contributor
Author
|
I've bumped the ocaml-qcow update from 0.13.0 to 0.14.0 |
psafont
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes to the interface, with the allocated data clusters now returned in
Qcow_mapping.t. Great reductions in memory usage, various other optimizations.Needs to be merged together with xapi-project/xen-api#6895