Skip to content

Update ocaml-qcow to 0.14.0#755

Merged
last-genius merged 3 commits into
xapi-project:6.99-lcmfrom
last-genius:asv/lcm-sparse-vhd-qcow
Apr 20, 2026
Merged

Update ocaml-qcow to 0.14.0#755
last-genius merged 3 commits into
xapi-project:6.99-lcmfrom
last-genius:asv/lcm-sparse-vhd-qcow

Conversation

@last-genius
Copy link
Copy Markdown
Contributor

Breaking changes to the interface, with the allocated data clusters now returned in Qcow_mapping.t. Great reductions in memory usage, various other optimizations.

Needs to be merged together with xapi-project/xen-api#6895

Copy link
Copy Markdown
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is expected because there's a breaking change in the API

last-genius added a commit to xcp-ng-rpms/xs-opam-repo that referenced this pull request Mar 6, 2026
Tarball generated from
last-genius/xs-opam@d1a83e3,
pending upstream merge in xapi-project/xs-opam#755

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
@last-genius last-genius force-pushed the asv/lcm-sparse-vhd-qcow branch from d1a83e3 to b3c6d07 Compare April 9, 2026 08:54
["qemu-utils"] {os-family = "ubuntu"}
["qemu-img"] {os-family = "fedora"}
["qemu-img"] {os-distribution = "rhel"}
["epel-release" "qemu-img"] {os-distribution = "centos"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this doesn't seem to enforce any distrivution package to when building xs-opam-repo, because it's not `os-family = "centos"

This seems to be what both xcp-ng and xenserver need now to avoid introducing conflicts regarding package names, and only enforce the dependency on the spec level when testing vhd-tool, if it's tested.

@last-genius last-genius force-pushed the asv/lcm-sparse-vhd-qcow branch from b3c6d07 to 14a4f93 Compare April 10, 2026 07:57
@lindig
Copy link
Copy Markdown
Collaborator

lindig commented Apr 10, 2026

# File "ocaml/qcow-stream-tool/qcow_stream_tool.ml", line 17, characters 8-24:
# 17 |         data_cluster_map
#              ^^^^^^^^^^^^^^^^
# Error: This expression has type Qcow_mapping.t
#        but an expression was expected of type 'a Qcow_types.Cluster.Map.t

@last-genius
Copy link
Copy Markdown
Contributor Author

last-genius commented Apr 10, 2026

# File "ocaml/qcow-stream-tool/qcow_stream_tool.ml", line 17, characters 8-24:
# 17 |         data_cluster_map
#              ^^^^^^^^^^^^^^^^
# Error: This expression has type Qcow_mapping.t
#        but an expression was expected of type 'a Qcow_types.Cluster.Map.t

Yes, the corresponding xapi PR drops the usage of this interface entirely: xapi-project/xen-api#6895 (review)

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
@last-genius last-genius force-pushed the asv/lcm-sparse-vhd-qcow branch from 14a4f93 to 5b7ee35 Compare April 20, 2026 08:31
@last-genius
Copy link
Copy Markdown
Contributor Author

I've bumped the ocaml-qcow update from 0.13.0 to 0.14.0

@last-genius last-genius changed the title Update ocaml-qcow to 0.13.0 Update ocaml-qcow to 0.14.0 Apr 20, 2026
@last-genius last-genius merged commit 1f9de17 into xapi-project:6.99-lcm Apr 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants